June 2026 - Devel - Nfs Ganesha List Archives

[XL] Change in ...nfs-ganesha[next]: Implement Internal NSM

by Frank Filz (GerritHub)

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238558?usp=email ) Change subject: Implement Internal NSM ...................................................................... Implement Internal NSM Add recovery database for recovery_fs and NSM code to support Ganesha taking over from rpc.statd. Ganesha will send SM_NOTIFY from the database and process SM_NOTIFY sent from clients. Change-Id: I8bcb3144cf1bea063c2f4800fe623d4b48045459 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/CMakeLists.txt M src/MainNFSD/libganesha_nfsd.ver M src/MainNFSD/nfs_admin_thread.c M src/MainNFSD/nfs_init.c M src/MainNFSD/nfs_rpc_dispatcher_thread.c M src/MainNFSD/nfs_worker_thread.c M src/Protocols/NLM/CMakeLists.txt M src/Protocols/NLM/nlm_util.c M src/Protocols/NLM/nsm.c M src/Protocols/XDR/xdr_nsm.c M src/SAL/nfs4_recovery.c M src/SAL/nlm_owner.c M src/SAL/recovery/recovery_fs.c M src/SAL/state_lock.c M src/include/gsh_recovery.h M src/include/nfs_init.h M src/include/nfs_proto_data.h M src/include/nfs_proto_functions.h M src/include/nsm.h M src/include/sal_data.h M src/include/sal_functions.h M src/support/nfs_read_conf.c 22 files changed, 1,668 insertions(+), 33 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/58/1238558/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238558?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I8bcb3144cf1bea063c2f4800fe623d4b48045459 Gerrit-Change-Number: 1238558 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

2 weeks, 2 days

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: SAL: recover gracefully from zombie lock-owner so_related_owner mismatch

by Nishant Puri (GerritHub)

Nishant Puri has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238516?usp=email ) Change subject: SAL: recover gracefully from zombie lock-owner so_related_owner mismatch ...................................................................... SAL: recover gracefully from zombie lock-owner so_related_owner mismatch When a kernel NFSv4 client crashes or its lease expires while holding a byte-range lock, the lock-owner ID it generated via the IDA allocator (ida_simple_get) may be recycled for a completely new process. When that new process opens the same file and requests a lock, the server calls create_nfs4_owner() and finds an existing STATE_LOCK_OWNER_NFSV4 entry in ht_nfs4_owner whose opaque owner bytes match -- but whose so_related_owner points to the old (now-stale) open owner rather than the new one. Before this change the code unconditionally logged a CRIT message and returned NULL, which propagated to the client as NFS4ERR_RESOURCE. Because the client retried indefinitely the file appeared permanently "zombie locked" from that perspective. The root cause on the client side is IDA-based lock-owner ID recycling (fixed in upstream Linux kernels by switching to atomic64_inc_return, but still present in RHEL 8 / kernel 4.18 based deployments). The fix distinguishes two cases at the point of mismatch: 1. so_lock_list is non-empty (zombie still holds active POSIX locks): This is a genuine conflict. Keep the existing CRIT log and return NULL so the client receives NFS4ERR_RESOURCE and can retry cleanly. 2. so_lock_list is empty (zombie has no active POSIX locks): The lock owner is a harmless zombie whose POSIX-lock state was already released (e.g. after LOCKU without a subsequent CLOSE or FREE_STATEID). Re-associate so_related_owner to the new open owner instead of failing, allowing the incoming LOCK request to succeed. Reference counts are maintained correctly: the stale open-owner reference is decremented and the new one is incremented, both under so_mutex. Change-Id: I9b76a2582b9066b196b01c75a2777a6dd335ee9a Signed-off-by: Nishant Puri <npuri(a)redhat.com> --- M src/SAL/nfs4_owner.c 1 file changed, 33 insertions(+), 7 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/16/1238516/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238516?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I9b76a2582b9066b196b01c75a2777a6dd335ee9a Gerrit-Change-Number: 1238516 Gerrit-PatchSet: 1 Gerrit-Owner: Nishant Puri <npuri(a)redhat.com>

2 weeks, 2 days

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: Remove call to mdcache_get_parent when the parent object cache is dis...

by Name of user not set (GerritHub)

inneek(a)gmail.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238515?usp=email ) Change subject: Remove call to mdcache_get_parent when the parent object cache is disabled. ...................................................................... Remove call to mdcache_get_parent when the parent object cache is disabled. Change-Id: I955442541cc1f3c9574d409590849bbecefd8cae Signed-off-by: Inna Batenkov <inneek(a)gmail.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c 1 file changed, 10 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/15/1238515/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238515?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I955442541cc1f3c9574d409590849bbecefd8cae Gerrit-Change-Number: 1238515 Gerrit-PatchSet: 1 Gerrit-Owner: inneek(a)gmail.com

2 weeks, 2 days

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: Fix dir chunk ref count leak

by Name of user not set (GerritHub)

shaharhoch(a)google.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238513?usp=email ) Change subject: Fix dir chunk ref count leak ...................................................................... Fix dir chunk ref count leak A recent change added a skip to a failure flow, but it called `mdcache_lru_unref_chunk` before the skip, but if we goto skip, we also unref the chunk there. This causes us to to dec-ref the chunk twice and release it while other dirs still reference to it. This can cause us memory corruption. Change-Id: I685b8e6977deeaa670cd80ebed041e79c8039252 Signed-off-by: Shahar Hochma <shaharhoch(a)google.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/13/1238513/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238513?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I685b8e6977deeaa670cd80ebed041e79c8039252 Gerrit-Change-Number: 1238513 Gerrit-PatchSet: 1 Gerrit-Owner: shaharhoch(a)google.com

2 weeks, 2 days

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: nfs4_owner: Fixed refcount leak.

by Yoni Couriel (GerritHub)

Yoni Couriel has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238510?usp=email ) Change subject: nfs4_owner: Fixed refcount leak. ...................................................................... nfs4_owner: Fixed refcount leak. Change-Id: Ia3437cd29d68408088f7ac3064d4996c396304ab Signed-off-by: Yoni Couriel <yonic(a)google.com> --- M src/SAL/nfs4_owner.c 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/10/1238510/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238510?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia3437cd29d68408088f7ac3064d4996c396304ab Gerrit-Change-Number: 1238510 Gerrit-PatchSet: 1 Gerrit-Owner: Yoni Couriel <yonic(a)google.com>

2 weeks, 2 days

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: state_lock: Fixed refcount leak.

by Yoni Couriel (GerritHub)

Yoni Couriel has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238509?usp=email ) Change subject: state_lock: Fixed refcount leak. ...................................................................... state_lock: Fixed refcount leak. Change-Id: I6b5bb51d996fb8b233352a8170677900ae8b31bf Signed-off-by: Yoni Couriel <yonic(a)google.com> --- M src/SAL/state_lock.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/09/1238509/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238509?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I6b5bb51d996fb8b233352a8170677900ae8b31bf Gerrit-Change-Number: 1238509 Gerrit-PatchSet: 1 Gerrit-Owner: Yoni Couriel <yonic(a)google.com>

2 weeks, 2 days

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: main: Add progress logging for initialization steps

by Lior Suliman (GerritHub)

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238452?usp=email to review the following change. Change subject: main: Add progress logging for initialization steps ...................................................................... main: Add progress logging for initialization steps Add explicit LogEvent and fprintf calls throughout the main initialization sequence. This tracks the execution flow and helps isolate failures during the startup process. Logging added for: - Memory and logging initialization - Core NFS and malloc checks - Process detaching (daemonization) - PID file creation - URL package and error type setup - Config parsing, log loading, and FSAL startup Change-Id: I805d65a16002259fd0188ef650050b35c887e717 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/MainNFSD/nfs_main.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/52/1238452/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238452?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I805d65a16002259fd0188ef650050b35c887e717 Gerrit-Change-Number: 1238452 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

2 weeks, 4 days

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: Replace assert with a check for memory availability in readdir.

by ofir vainshtein (GerritHub)

ofir vainshtein has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238448?usp=email ) Change subject: Replace assert with a check for memory availability in readdir. ...................................................................... Replace assert with a check for memory availability in readdir. The assert ensuring `mem_avail >= pos_start` has been replaced with an explicit check. If there isn't enough memory, a warning is logged, and the function bails out to the failure path. This prevents potential issues in production builds where asserts are often disabled. Change-Id: Idc8fead167910b65d0fff47eafd1643f1db70355 Signed-off-by: Ofir Vainshtein <ofirvins(a)google.com> --- M src/Protocols/NFS/nfs4_op_readdir.c 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/48/1238448/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238448?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Idc8fead167910b65d0fff47eafd1643f1db70355 Gerrit-Change-Number: 1238448 Gerrit-PatchSet: 1 Gerrit-Owner: ofir vainshtein <ofirvins(a)google.com>

2 weeks, 4 days

1
0
0 / 0

[M] Change in ...nfs-ganesha[next]: Refactor: Add bounds-checked fattr comparison in nfs4_Fattr_cmp

by ofir vainshtein (GerritHub)

ofir vainshtein has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238447?usp=email ) Change subject: Refactor: Add bounds-checked fattr comparison in nfs4_Fattr_cmp ...................................................................... Refactor: Add bounds-checked fattr comparison in nfs4_Fattr_cmp Introduced a helper function `fattrs_is_equal` to safely compare portions of fattr4 buffers, including bounds checks. Replaced direct memcmp calls in `nfs4_Fattr_cmp` with calls to this new helper. Also, optimized the FATTR4_ACL comparison to use a single memcmp call for the entire attribute value. Change-Id: Ifbd2905b8d4e41ffb58f0b43ba7b0b70977443c3 Signed-off-by: Ofir Vainshtein <ofirvins(a)google.com> --- M src/Protocols/NFS/nfs_proto_tools.c 1 file changed, 42 insertions(+), 36 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/47/1238447/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238447?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ifbd2905b8d4e41ffb58f0b43ba7b0b70977443c3 Gerrit-Change-Number: 1238447 Gerrit-PatchSet: 1 Gerrit-Owner: ofir vainshtein <ofirvins(a)google.com>

2 weeks, 4 days

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: Replace assert with a check for empty client record value.

by ofir vainshtein (GerritHub)

ofir vainshtein has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238446?usp=email ) Change subject: Replace assert with a check for empty client record value. ...................................................................... Replace assert with a check for empty client record value. The assert on `len` could cause a crash if the client record value was empty. This change replaces the assert with a check that logs a critical error and returns NULL when `len` is 0, preventing a potential crash. Change-Id: I8f60ca24db4e00417fd8fb921e0541bb73fd6dfa Signed-off-by: Ofir Vainshtein <ofirvins(a)google.com> --- M src/SAL/nfs4_clientid.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/46/1238446/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238446?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I8f60ca24db4e00417fd8fb921e0541bb73fd6dfa Gerrit-Change-Number: 1238446 Gerrit-PatchSet: 1 Gerrit-Owner: ofir vainshtein <ofirvins(a)google.com>

2 weeks, 4 days

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

Devel June 2026