Martin Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201746?usp=email ) Change subject: fsal: Make fsal_start_global_io() easier to understand ...................................................................... fsal: Make fsal_start_global_io() easier to understand Use early returns for success. Don't set *out_fd on error and then use it to decide which debug message to log - just log a message for each failure. When both fail there will now be 2 messages logged, but debug level logging is pretty busy anyway. This also makes subsequent changes more straightforward. Signed-off-by: Martin Schwenke <mschwenke(a)ddn.com&gt; Change-Id: I6ff301d92f6e9f5d4a58edf8df065baf5d8ceadb --- M src/FSAL/commonlib.c 1 file changed, 12 insertions(+), 12 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/46/1201746/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201746?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I6ff301d92f6e9f5d4a58edf8df065baf5d8ceadb Gerrit-Change-Number: 1201746 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Schwenke <martin(a)meltin.net&gt;