August 2024 - Devel - NFS Ganesha List Archives

[S] Change in ...nfs-ganesha[next]: Connection Manager: Fix Coverity CID 502085 - check return of sprint_...
by Frank Filz (GerritHub) 30 Aug '24

30 Aug '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1200460?usp=email ) Change subject: Connection Manager: Fix Coverity CID 502085 - check return of sprint_sockip ...................................................................... Connection Manager: Fix Coverity CID 502085 - check return of sprint_sockip Change-Id: Ia1a8db4f2e739e6366b927f9642033a6a46c7ec2 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/RPCAL/connection_manager.c 1 file changed, 10 insertions(+), 5 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/60/1200460/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1200460?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia1a8db4f2e739e6366b927f9642033a6a46c7ec2 Gerrit-Change-Number: 1200460 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[XS] Change in ...nfs-ganesha[next]: PSEUDO: Fix Coverity CID 502071 - log junction_export with lock held
by Frank Filz (GerritHub) 30 Aug '24

30 Aug '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1200371?usp=email ) Change subject: PSEUDO: Fix Coverity CID 502071 - log junction_export with lock held ...................................................................... PSEUDO: Fix Coverity CID 502071 - log junction_export with lock held Change-Id: Id83b3a964c1710b0eb8756790c94ee2110749fe6 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/Protocols/NFS/nfs4_pseudo.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/71/1200371/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1200371?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id83b3a964c1710b0eb8756790c94ee2110749fe6 Gerrit-Change-Number: 1200371 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[S] Change in ...nfs-ganesha[next]: Fix error code on exclusive open when file exists
by Name of user not set (GerritHub) 30 Aug '24

30 Aug '24

shaharhoch(a)google.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1200368?usp=email ) Change subject: Fix error code on exclusive open when file exists ...................................................................... Fix error code on exclusive open when file exists Previously, on execlusive open when the file exists and we don't have permission to open it, we returned ERR_ACCESS. This is not the correct error code, if the file exists we should return ERR_EXIST Change-Id: I71f5811bdcfaaa7c63d4edc268b631341c426bc0 Signed-off-by: Shahar Hochma <shaharhoch(a)google.com> --- M src/FSAL/fsal_helper.c 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/68/1200368/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1200368?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I71f5811bdcfaaa7c63d4edc268b631341c426bc0 Gerrit-Change-Number: 1200368 Gerrit-PatchSet: 1 Gerrit-Owner: shaharhoch(a)google.com

1 0

[XS] Change in ...nfs-ganesha[next]: reaper: Fox Coverity CID 502101 - use unsigned long for values
by Frank Filz (GerritHub) 29 Aug '24

29 Aug '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1200310?usp=email ) Change subject: reaper: Fox Coverity CID 502101 - use unsigned long for values ...................................................................... reaper: Fox Coverity CID 502101 - use unsigned long for values Change-Id: I39bbb9581db23131c73830496c209a5c3badce53 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/MainNFSD/nfs_reaper_thread.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/10/1200310/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1200310?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I39bbb9581db23131c73830496c209a5c3badce53 Gerrit-Change-Number: 1200310 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[S] Change in ...nfs-ganesha[next]: FSAL: Fix Coverity CID 502234 - Always use exp_lock for mounted_on_fi...
by Frank Filz (GerritHub) 29 Aug '24

29 Aug '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1200309?usp=email ) Change subject: FSAL: Fix Coverity CID 502234 - Always use exp_lock for mounted_on_fileid ...................................................................... FSAL: Fix Coverity CID 502234 - Always use exp_lock for mounted_on_fileid Change-Id: I3ee356f0be4c13ea760c82d3d468812a8ea8fe13 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/fsal_helper.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/09/1200309/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1200309?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I3ee356f0be4c13ea760c82d3d468812a8ea8fe13 Gerrit-Change-Number: 1200309 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[S] Change in ...nfs-ganesha[next]: FSAL_CEPH - Add inode invalidation callback
by Sachin Punadikar (GerritHub) 29 Aug '24

29 Aug '24

Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1200259?usp=email ) Change subject: FSAL_CEPH - Add inode invalidation callback ...................................................................... FSAL_CEPH - Add inode invalidation callback Ceph client code has provision to call upper layer routine in case of inode attribute changes. Ganesha needs to invalidate its cached inode metadata when ceph client asks to do. Change-Id: I169aeea85a961eff1e1df96b5717cb5a51df842c Signed-off-by: Sachin Punadikar <sachin.punadikar(a)ibm.com> --- M src/FSAL/FSAL_CEPH/main.c 1 file changed, 26 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/59/1200259/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1200259?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I169aeea85a961eff1e1df96b5717cb5a51df842c Gerrit-Change-Number: 1200259 Gerrit-PatchSet: 1 Gerrit-Owner: Sachin Punadikar <sachin.punadikar(a)ibm.com>

1 0

[S] Change in ...nfs-ganesha[next]: Ignore prctl failure for containerized setup
by Sachin Punadikar (GerritHub) 29 Aug '24

29 Aug '24

Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1200210?usp=email ) Change subject: Ignore prctl failure for containerized setup ...................................................................... Ignore prctl failure for containerized setup In containerized setups, prctl call fails with EPERM. This error should be accepted, and Ganesha should continue instead of exiting. Change-Id: I4821c1707bf99e2e53e7cb15e93eada8044a1811 Signed-off-by: Sachin Punadikar <sachin.punadikar(a)ibm.com> --- M src/MainNFSD/nfs_main.c 1 file changed, 24 insertions(+), 5 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/10/1200210/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1200210?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I4821c1707bf99e2e53e7cb15e93eada8044a1811 Gerrit-Change-Number: 1200210 Gerrit-PatchSet: 1 Gerrit-Owner: Sachin Punadikar <sachin.punadikar(a)ibm.com>

1 0

[XS] Change in ...nfs-ganesha[next]: FSAL_VFS: Fix Coverity CID 502222 Remove extraneous retval assignmemt
by Frank Filz (GerritHub) 28 Aug '24

28 Aug '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1200175?usp=email ) Change subject: FSAL_VFS: Fix Coverity CID 502222 Remove extraneous retval assignmemt ...................................................................... FSAL_VFS: Fix Coverity CID 502222 Remove extraneous retval assignmemt Change-Id: I024aaf66d233f07e750b1344fb1ef6325521ad34 --- M src/FSAL/FSAL_VFS/file.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/75/1200175/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1200175?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I024aaf66d233f07e750b1344fb1ef6325521ad34 Gerrit-Change-Number: 1200175 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[S] Change in ...nfs-ganesha[next]: FSAL_MEM: Fix Coverity CID 502053 Access mfe_objs without lock
by Frank Filz (GerritHub) 28 Aug '24

28 Aug '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1200173?usp=email ) Change subject: FSAL_MEM: Fix Coverity CID 502053 Access mfe_objs without lock ...................................................................... FSAL_MEM: Fix Coverity CID 502053 Access mfe_objs without lock Change-Id: I1a50e8cca2933f63aa95fee53c89dc42a5f9b464 --- M src/FSAL/FSAL_MEM/mem_up.c 1 file changed, 7 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/73/1200173/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1200173?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1a50e8cca2933f63aa95fee53c89dc42a5f9b464 Gerrit-Change-Number: 1200173 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[S] Change in ...nfs-ganesha[next]: FSAL_MEM: Fix Coverity CID 502144 and 502168 - use after free
by Frank Filz (GerritHub) 28 Aug '24

28 Aug '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1200172?usp=email ) Change subject: FSAL_MEM: Fix Coverity CID 502144 and 502168 - use after free ...................................................................... FSAL_MEM: Fix Coverity CID 502144 and 502168 - use after free Change-Id: I2c4adc6441d61dce27e799dea24dabec138f77d8 --- M src/FSAL/FSAL_MEM/mem_handle.c 1 file changed, 10 insertions(+), 8 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/72/1200172/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1200172?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I2c4adc6441d61dce27e799dea24dabec138f77d8 Gerrit-Change-Number: 1200172 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 0