August 2024 - Devel - NFS Ganesha List Archives

[XS] Change in ...nfs-ganesha[next]: scripts: Add missing Debian dependency for container builds
by Martin Schwenke (GerritHub) 09 Aug '24

09 Aug '24

Martin Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1199251?usp=email ) Change subject: scripts: Add missing Debian dependency for container builds ...................................................................... scripts: Add missing Debian dependency for container builds Signed-off-by: Martin Schwenke <mschwenke(a)ddn.com> Change-Id: I751aa380c852372b37611ac9868a0e9d6c6eb043 --- M src/scripts/podman/install-packages.sh 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/51/1199251/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1199251?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I751aa380c852372b37611ac9868a0e9d6c6eb043 Gerrit-Change-Number: 1199251 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Schwenke <martin(a)meltin.net>

1 0

Announce Push of V6-dev.18 - PLEASE READ ME
by Frank Filz 09 Aug '24

09 Aug '24

Branch next Tag:V6-dev.18 NOTE: This merge includes and ntirpc pullup, please update your submodule NOTE: We are on the verge of tagging V6.0. There is room for a few more patches if they can be complete Monday or Tuesday. We will also be merging changes that make LTTNG tracing easier to use, and then a reformat with clang. Following that reformat, there will be new commit hooks and we will no longer use checkpatch.pl. Please be prepared to rebase (with manual merge) any patches that do no get merged before those two major hits. Thanks Frank Merge Highlights * RDMA fixes * Release the export ref in special cases * Improve refCount debuggability - StateOwner * ClientID and RefCount Log Updates * Release state_owner ref in nfs4_Check_Stateid when client lease has expired * Fix so_refcount leak * atomic: remove broken __sync-based implementations * wait_to_start_io now allows other threads to proceed when IO cannot start. * Do not unlock obj_lock twice, that leads to undefined behavior. * Skip Delegation Recall Async task, if the client_id goes stale * Handle ASync Completion case, when op_ctx is never set or gets reset * Skip backtraces & cores during shutdown * Convert mdc_exp_lock to mutex. * Convert cih_lock to mutext. * MDCACHE: Remove unused CIH_GET_RLOCK/CIH_GET_WLOCK flags * Fix and refactor LTTNG compilation * Delete unnecessary conditional statements. * gsh_libunwind having some uninitialised fields * fix(monitoring): make GetExportLabels thread-safe * Unblock important log entries Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: d8a169612 Frank S. Filz V6-dev.18 e12715b19 Frank S. Filz libntirpc pullup ac1564687 Kyle Lippincott atomic: remove broken __sync-based implementations 5df87a39b Sachin Punadikar Unblock important log entries f1013e19c Sachin Punadikar Fix so_refcount leak 780b87aad zhitaoli fix(monitoring): make GetExportLabels thread-safe 9dc0c76fb Xueqian Hu gsh_libunwind having some uninitialised fields c2e586b8c izxl007 Delete unnecessary conditional statements. a2db01182 David Rieber wait_to_start_io now allows other threads to proceed when IO cannot start. 560f9e0d0 David Rieber Do not unlock obj_lock twice, that leads to undefined behavior. 89172c032 Shahar Hochma Fix and refactor LTTNG compilation 9effe985b Frank S. Filz MDCACHE: Remove unused CIH_GET_RLOCK/CIH_GET_WLOCK flags e00c012a8 Gaurav Gangalwar Convert cih_lock to mutext. 2b7160126 Gaurav Gangalwar Convert mdc_exp_lock to mutex. mdc_clean_entry uses this lock as rwlock, so better to convert it mutex. Using pthread_rwlock causing performance overhead during heavy mdcache lru reaping. Other places where its used ad rdlock are rare like mdcache_unexport/umount. dc07e558d Rojin George Release state_owner ref in nfs4_Check_Stateid when client lease has expired 63d81d923 Rojin George ClientID and RefCount Log Updates 4ba276d59 Rojin George Skip backtraces & cores during shutdown 0c17ef48a Rojin George RDMA fix needed to work with new iovev using io_data. 5c1ad5803 Rojin George Remove unused RDMA Configurations - rq_depth & sq_depth 130d579a7 Rojin George Fix compilation issue in io_data's release func eb164028b Rojin George Improve refCount debuggability - StateOwner 29a432d5b Rojin George Ignore Mac DS_Store file 45db3e4f3 Rojin George Handle ASync Completion case, when op_ctx is never set or gets reset 46177f6f5 Rojin George Skip Delegation Recall Async task, if the client_id goes stale bd23d8847 Rojin George Release the export ref in special cases

1 0

possible nfs4_op_close simplication
by David Rieber 09 Aug '24

09 Aug '24

NFSv4 says even though CLOSE returns a stateid, this stateid is not useful to the client and should be treated as deprecated: https://www.rfc-editor.org/rfc/rfc7530#section-16.2.5 nfs4_op_close could set open_stateid in the response just like it does for NFSv4.1. Also, to make the logic clearer, I think this case inside nfs4_Check_Stateid should set `status = NFS4ERR_REPLAY;` and `goto replay` (currently it does `goto success`): https://github.com/nfs-ganesha/nfs-ganesha/blob/next/src/SAL/nfs4_state_id.… I would also separate the error handling in nfs4_op_close: https://github.com/nfs-ganesha/nfs-ganesha/blob/next/src/Protocols/NFS/nfs4… I think the logic would be clearer if we add an explicit `if (nfs_status == NFS4ERR_REPLAY) { ... }`.

1 0

[XS] Change in ...nfs-ganesha[next]: Add libntirpc_tracepoints.so to Ganesha lttng package
by Name of user not set (GerritHub) 09 Aug '24

09 Aug '24

shaharhoch(a)google.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1199242?usp=email ) Change subject: Add libntirpc_tracepoints.so to Ganesha lttng package ...................................................................... Add libntirpc_tracepoints.so to Ganesha lttng package Change-Id: I6fe1b108f56f6d3f991aeeced8cd3294d22b1170 Signed-off-by: Shahar Hochma <shaharhoch(a)google.com> --- M src/nfs-ganesha.spec-in.cmake 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/42/1199242/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1199242?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I6fe1b108f56f6d3f991aeeced8cd3294d22b1170 Gerrit-Change-Number: 1199242 Gerrit-PatchSet: 1 Gerrit-Owner: shaharhoch(a)google.com

1 0

[XL] Change in ...nfs-ganesha[next]: Change existing tracepoints to use generated tracepoints
by Name of user not set (GerritHub) 09 Aug '24

09 Aug '24

shaharhoch(a)google.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1199241?usp=email ) Change subject: Change existing tracepoints to use generated tracepoints ...................................................................... Change existing tracepoints to use generated tracepoints Change-Id: Id6faef99432c441f2497b8940daa0ea454ce9f03 Signed-off-by: Shahar Hochma <shaharhoch(a)google.com> --- M src/FSAL/FSAL_CEPH/export.c M src/FSAL/FSAL_CEPH/handle.c M src/FSAL/FSAL_GLUSTER/export.c M src/FSAL/FSAL_GLUSTER/handle.c M src/FSAL/FSAL_MEM/mem_export.c M src/FSAL/FSAL_MEM/mem_handle.c M src/FSAL/FSAL_MEM/mem_int.h M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_hash.h M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c M src/MainNFSD/nfs_rpc_dispatcher_thread.c M src/MainNFSD/nfs_worker_thread.c M src/Protocols/NFS/nfs4_Compound.c M src/Protocols/NFS/nfs4_op_create_session.c M src/SAL/nfs41_session_id.c M src/SAL/nfs4_state.c D src/include/gsh_lttng/fsal_ceph.h D src/include/gsh_lttng/fsal_gluster.h D src/include/gsh_lttng/fsal_mem.h D src/include/gsh_lttng/logger.h D src/include/gsh_lttng/mdcache.h D src/include/gsh_lttng/nfs4.h D src/include/gsh_lttng/nfs_rpc.h D src/include/gsh_lttng/state.h A src/include/gsh_xprt_tracepoint.h M src/log/log_functions.c M src/tracing/lttng_defines.c M src/tracing/lttng_probes.c 28 files changed, 401 insertions(+), 2,611 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/41/1199241/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1199241?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id6faef99432c441f2497b8940daa0ea454ce9f03 Gerrit-Change-Number: 1199241 Gerrit-PatchSet: 1 Gerrit-Owner: shaharhoch(a)google.com

1 0

[L] Change in ...nfs-ganesha[next]: Integrate with trace generator
by Name of user not set (GerritHub) 09 Aug '24

09 Aug '24

shaharhoch(a)google.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1199240?usp=email ) Change subject: Integrate with trace generator ...................................................................... Integrate with trace generator Change-Id: I5b57f9eea5758cb3ca7ff4357c6fdab78a5b80e4 Signed-off-by: Shahar Hochma <shaharhoch(a)google.com> --- M .gitignore M src/CMakeLists.txt M src/FSAL/FSAL_PROXY_V3/CMakeLists.txt M src/FSAL/FSAL_PROXY_V4/handle_mapping/CMakeLists.txt M src/FSAL/FSAL_PSEUDO/CMakeLists.txt M src/FSAL/FSAL_SAUNAFS/CMakeLists.txt M src/FSAL/FSAL_VFS/os/CMakeLists.txt M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/CMakeLists.txt M src/FSAL/Stackable_FSALs/FSAL_NULL/CMakeLists.txt M src/MainNFSD/CMakeLists.txt M src/Protocols/9P/CMakeLists.txt M src/Protocols/NFS/CMakeLists.txt M src/Protocols/NFSACL/CMakeLists.txt M src/Protocols/NLM/CMakeLists.txt M src/Protocols/RQUOTA/CMakeLists.txt M src/Protocols/XDR/CMakeLists.txt M src/RPCAL/CMakeLists.txt M src/SAL/CMakeLists.txt M src/avl/CMakeLists.txt M src/cidr/CMakeLists.txt M src/config_parsing/CMakeLists.txt M src/dbus/CMakeLists.txt M src/hashtable/CMakeLists.txt M src/idmapper/CMakeLists.txt A src/include/gsh_lttng/gsh_lttng.h M src/log/CMakeLists.txt M src/os/CMakeLists.txt M src/support/CMakeLists.txt M src/tracing/CMakeLists.txt M src/tracing/README.md M src/tracing/lttng_defines.c M src/tracing/lttng_probes.c 32 files changed, 372 insertions(+), 49 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/40/1199240/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1199240?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I5b57f9eea5758cb3ca7ff4357c6fdab78a5b80e4 Gerrit-Change-Number: 1199240 Gerrit-PatchSet: 1 Gerrit-Owner: shaharhoch(a)google.com

1 0

[XS] Change in ...nfs-ganesha[next]: Update libntirpc submodule to contain LTTNG trace generator
by Name of user not set (GerritHub) 09 Aug '24

09 Aug '24

shaharhoch(a)google.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1199239?usp=email ) Change subject: Update libntirpc submodule to contain LTTNG trace generator ...................................................................... Update libntirpc submodule to contain LTTNG trace generator Change-Id: I4efe2aaf09b9dcb2358ae89c0474b7b68150db92 Signed-off-by: Shahar Hochma <shaharhoch(a)google.com> --- M src/libntirpc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/39/1199239/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1199239?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I4efe2aaf09b9dcb2358ae89c0474b7b68150db92 Gerrit-Change-Number: 1199239 Gerrit-PatchSet: 1 Gerrit-Owner: shaharhoch(a)google.com

1 0

[S] Change in ...nfs-ganesha[next]: Allow loading of lttng traces on Ganesha startup
by Name of user not set (GerritHub) 09 Aug '24

09 Aug '24

shaharhoch(a)google.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1199238?usp=email ) Change subject: Allow loading of lttng traces on Ganesha startup ...................................................................... Allow loading of lttng traces on Ganesha startup I moved the ganesha trace lib install path to lib dir so it can be found during loading Change-Id: I8e2368e12aade38e38e0b920846efa8fac6a9b8e Signed-off-by: Shahar Hochma <shaharhoch(a)google.com> --- M src/MainNFSD/nfs_main.c M src/nfs-ganesha.spec-in.cmake M src/tracing/CMakeLists.txt 3 files changed, 44 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/38/1199238/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1199238?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I8e2368e12aade38e38e0b920846efa8fac6a9b8e Gerrit-Change-Number: 1199238 Gerrit-PatchSet: 1 Gerrit-Owner: shaharhoch(a)google.com

1 0

[XS] Change in ...nfs-ganesha[next]: V6-dev.18
by Frank Filz (GerritHub) 09 Aug '24

09 Aug '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1199229?usp=email ) Change subject: V6-dev.18 ...................................................................... V6-dev.18 Change-Id: I27f5cbb75e2e147462ac1a31f1f8a624a8db118d Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/CMakeLists.txt 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/29/1199229/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1199229?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I27f5cbb75e2e147462ac1a31f1f8a624a8db118d Gerrit-Change-Number: 1199229 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[XS] Change in ...nfs-ganesha[next]: libntirpc pullup
by Frank Filz (GerritHub) 09 Aug '24

09 Aug '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1199228?usp=email ) Change subject: libntirpc pullup ...................................................................... libntirpc pullup Change-Id: Ic873f7311d5654492595edb891223e7f0fddccf8 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/libntirpc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/28/1199228/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1199228?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ic873f7311d5654492595edb891223e7f0fddccf8 Gerrit-Change-Number: 1199228 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 0