August 2024 - Devel - NFS Ganesha List Archives

[S] Change in ...nfs-ganesha[next]: MDCACHE: Remove unused CIH_GET_RLOCK/CIH_GET_WLOCK flags
by Frank Filz (GerritHub) 09 Aug '24

09 Aug '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1199227?usp=email ) Change subject: MDCACHE: Remove unused CIH_GET_RLOCK/CIH_GET_WLOCK flags ...................................................................... MDCACHE: Remove unused CIH_GET_RLOCK/CIH_GET_WLOCK flags Change-Id: I3842aacd99a6c393fd0b8320f895fcc2ec57741d Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_hash.h M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_up.c 4 files changed, 8 insertions(+), 15 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/27/1199227/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1199227?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I3842aacd99a6c393fd0b8320f895fcc2ec57741d Gerrit-Change-Number: 1199227 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

FW: [nfsv4] Announcing the Fall 2024 Bakeathon
by Frank Filz 08 Aug '24

08 Aug '24

-----Original Message----- From: Steve Dickson [mailto:steved@redhat.com] Sent: Thursday, August 8, 2024 12:17 PM To: Linux NFS Mailing list <linux-nfs(a)vger.kernel.org>; NFSv4 <nfsv4(a)ietf.org> Subject: [nfsv4] Announcing the Fall 2024 Bakeathon Hello, Red Hat is pleased to announce that we'll be hosting the Fall 2024 Bakeathon at our Westford office in Massachusetts, US. The event will be F2F as well as virtual. Hoping to draw as many participants as possible. Details, event registration, network info and hotel info are here [1]. Date: Mon Oct 21 to Fri Oct 25 Address: Red Hat, 314 Littleton Rd, Westford, MA Event Registration: [2] We have "talks at 2" (EST) [3] everyday... Please feel free sign up for a talk if you want to present a topic the to the community... They are very informal... Definitely feel free to attended! Any questions please send them to bakeathon-contact(a)googlegroups.com I hope to see you there... One way or the other! steved. [1] http://www.nfsv4bat.org/Events/2024/Oct/BAT/index.html [2] https://docs.google.com/spreadsheets/d/1kJfCNeKyQhVRaV8p3X_2THsERegsgTOpkkd… [3] https://docs.google.com/spreadsheets/d/1kJfCNeKyQhVRaV8p3X_2THsERegsgTOpkkd… _______________________________________________ nfsv4 mailing list -- nfsv4(a)ietf.org To unsubscribe send an email to nfsv4-leave(a)ietf.org

1 0

[L] Change in ...nfs-ganesha[next]: atomics: remove broken __sync-based implementations
by Kyle Lippincott (GerritHub) 07 Aug '24

07 Aug '24

Kyle Lippincott has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1199063?usp=email ) Change subject: atomics: remove broken __sync-based implementations ...................................................................... atomics: remove broken __sync-based implementations The "new" version of these functions, using functions with an `__atomic` prefix have been available since gcc 4.7, released March 2012, which is more than 12 years ago. We can just assume that the compilers in use today support them; if this is incorrect, then we'll get an error message during compilation. This is not purely a code cleanup. Clang presents itself as gcc 4.2, which means it's using the `__sync` versions of the functions per the version checking being done at the top of the file, even though it supports the `__atomic` versions. This is a missed performance opportunity, even if the function implementations were correct, as the `__atomic` versions may be faster. There's a reason we prefer them if they're available, after all. Furthermore, the versions of these functions that are based on the `__sync` versions are broken. An example: ``` static inline int32_t atomic_inc_unless_0_int32_t(int32_t *var) { int32_t cur, newv; bool changed; cur = atomic_fetch_int32_t(var); do { if (cur == 0) return 0; newv = cur + 1; changed = __sync_val_compare_and_swap(var, cur, newv) != cur; } while (!changed); return newv; } ``` This has multiple issues: - In the 99.99% case, we'll: - fetch `*var` into `cur`, - set `newv = cur + 1`, - then atomically (possibly "transactionally") perform an operation equivalent to: ``` old_value = *var; if (*var == cur) *var = newv; return old_value; ``` - This then does `changed = old_value != cur`, which is incorrect since `__sync_val_compare_and_swap` returns the _original_ value (whether it changed or not). This isn't correct; this should be `changed = old_value == cur`, not `!=`. - Basically: if nothing weird happens, we always go through the loop _twice_. - In the tragic 0.01% case, where some other thread modifies `var` between the `atomic_fetch_int32_t` and `__sync_val_compare_and_swap`, we'll get that other thread's value from `__sync_val_compare_and_swap`, which won't be equal to `cur`, so we just skip incrementing at all. - The implementation can't be fixed by just using the correct comparison, because then you run into the possibility of an infinite loop: ``` cur = 10; // atomic_fetch_int32_t(var) do { newv = 11; // cur + 1; // !!!! Some other thread sets *var to 50 !!!! changed = false; // 50 == 10, since sync_val... returns 50 } while (!changed); // loops until some other thread sets it to 10 ``` - We could capture the value from `__sync_val_compare_and_swap`, and update `cur`, or we could switch to `__sync_bool_compare_and_swap` and move the `atomic_fetch_int32_t` into the `do {} while` loop to resolve this other issue. - It seems like there might have been some confusion about what the `_and_swap` part of the function name meant (i.e. that it updated `cur`), and also an assumption that the function would return the _new_ value, like `__atomic_add_fetch` does. Ultimately, however, these `__sync` functions are old, the replacements (`__atomic`) are also old and broadly available, and maintaining two implementations of these functions is a cost that we shouldn't have to take. Remove the broken, legacy versions of the atomic functions that use the `__sync` compiler builtins. Change-Id: I1851d4e37cb9ecfeb5959736f682a9625cc42be5 Signed-off-by: Kyle Lippincott <spectral(a)google.com> --- M src/include/abstract_atomic.h M src/include/atomic_utils.h 2 files changed, 0 insertions(+), 684 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/63/1199063/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1199063?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1851d4e37cb9ecfeb5959736f682a9625cc42be5 Gerrit-Change-Number: 1199063 Gerrit-PatchSet: 1 Gerrit-Owner: Kyle Lippincott <spectral(a)google.com>

1 0

[S] Change in ...nfs-ganesha[next]: Relase state_onwer ref in nfs4_Check_Stateid when client lease has ex...
by Rojin George (GerritHub) 07 Aug '24

07 Aug '24

Rojin George has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1199019?usp=email ) Change subject: Relase state_onwer ref in nfs4_Check_Stateid when client lease has expired ...................................................................... Relase state_onwer ref in nfs4_Check_Stateid when client lease has expired Change-Id: If66dc995ed13a8cde0f8c9c6ccc0adce143293f6 Signed-off-by: Rojin George <itsmerojin(a)gmail.com> --- M src/Protocols/NFS/nfs4_op_bind_conn.c M src/Protocols/NFS/nfs4_op_lockt.c M src/Protocols/NFS/nfs4_op_open.c M src/Protocols/NFS/nfs4_op_release_lockowner.c M src/Protocols/NFS/nfs4_op_renew.c M src/Protocols/NFS/nfs4_op_sequence.c M src/SAL/nfs4_lease.c M src/SAL/nfs4_state_id.c M src/include/sal_functions.h 9 files changed, 23 insertions(+), 12 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/19/1199019/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1199019?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If66dc995ed13a8cde0f8c9c6ccc0adce143293f6 Gerrit-Change-Number: 1199019 Gerrit-PatchSet: 1 Gerrit-Owner: Rojin George <itsmerojin(a)gmail.com>

1 0

[M] Change in ...nfs-ganesha[next]: ClientID and RefCount Log Updates
by Rojin George (GerritHub) 06 Aug '24

06 Aug '24

Rojin George has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1198955?usp=email ) Change subject: ClientID and RefCount Log Updates ...................................................................... ClientID and RefCount Log Updates Change-Id: Ia7b57d5ee4d92c3bbe2ab53d1e86f32afc5e42ee Signed-off-by: Rojin George <itsmerojin(a)gmail.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_export.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_main.c M src/FSAL/Stackable_FSALs/FSAL_NULL/export.c M src/FSAL/default_methods.c M src/FSAL/fsal_destroyer.c M src/FSAL/fsal_manager.c M src/SAL/nfs4_clientid.c M src/SAL/nfs4_state_id.c M src/SAL/nlm_owner.c M src/SAL/nlm_state.c M src/SAL/state_lock.c M src/SAL/state_misc.c M src/include/sal_functions.h M src/support/ds.c M src/support/export_mgr.c M src/support/exports.c 16 files changed, 86 insertions(+), 87 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/55/1198955/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1198955?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia7b57d5ee4d92c3bbe2ab53d1e86f32afc5e42ee Gerrit-Change-Number: 1198955 Gerrit-PatchSet: 1 Gerrit-Owner: Rojin George <itsmerojin(a)gmail.com>

1 0

[M] Change in ...nfs-ganesha[next]: ClientID and RefCount Log Updates
by Rojin George (GerritHub) 06 Aug '24

06 Aug '24

Rojin George has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1198954?usp=email ) Change subject: ClientID and RefCount Log Updates ...................................................................... ClientID and RefCount Log Updates Change-Id: I58aca35d9154a63fba460b86543007fc326c76b8 Signed-off-by: Rojin George <itsmerojin(a)gmail.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_export.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_main.c M src/FSAL/Stackable_FSALs/FSAL_NULL/export.c M src/FSAL/default_methods.c M src/FSAL/fsal_destroyer.c M src/FSAL/fsal_manager.c M src/SAL/nfs4_clientid.c M src/SAL/nfs4_state_id.c M src/SAL/nlm_owner.c M src/SAL/nlm_state.c M src/SAL/state_lock.c M src/SAL/state_misc.c M src/include/sal_functions.h M src/support/ds.c M src/support/export_mgr.c M src/support/exports.c 16 files changed, 84 insertions(+), 86 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/54/1198954/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1198954?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I58aca35d9154a63fba460b86543007fc326c76b8 Gerrit-Change-Number: 1198954 Gerrit-PatchSet: 1 Gerrit-Owner: Rojin George <itsmerojin(a)gmail.com>

1 0

[M] Change in ...nfs-ganesha[next]: ClientID and RefCount Log Updates
by Rojin George (GerritHub) 06 Aug '24

06 Aug '24

Rojin George has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1198952?usp=email ) Change subject: ClientID and RefCount Log Updates ...................................................................... ClientID and RefCount Log Updates Change-Id: I9aa3ad10efaa4e7a612b5598fc09b3af98f0f28b Signed-off-by: Rojin George <itsmerojin(a)gmail.com> --- M src/FSAL/default_methods.c M src/FSAL/fsal_manager.c M src/SAL/nfs4_clientid.c M src/SAL/nfs4_state_id.c M src/SAL/nlm_owner.c M src/SAL/state_lock.c 6 files changed, 43 insertions(+), 45 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/52/1198952/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1198952?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I9aa3ad10efaa4e7a612b5598fc09b3af98f0f28b Gerrit-Change-Number: 1198952 Gerrit-PatchSet: 1 Gerrit-Owner: Rojin George <itsmerojin(a)gmail.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Skip backtraces & cores during shutdown
by Rojin George (GerritHub) 06 Aug '24

06 Aug '24

Rojin George has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1198951?usp=email ) Change subject: Skip backtraces & cores during shutdown ...................................................................... Skip backtraces & cores during shutdown Change-Id: I107e04e8952d432d15cb13868ce22e356861adee Signed-off-by: Rojin George <itsmerojin(a)gmail.com> --- M src/MainNFSD/nfs_init.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/51/1198951/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1198951?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I107e04e8952d432d15cb13868ce22e356861adee Gerrit-Change-Number: 1198951 Gerrit-PatchSet: 1 Gerrit-Owner: Rojin George <itsmerojin(a)gmail.com>

1 0

[XS] Change in ...nfs-ganesha[next]: gsh_libunwind having some uninitialised fields
by Xueqian Hu (GerritHub) 05 Aug '24

05 Aug '24

Xueqian Hu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1198891?usp=email ) Change subject: gsh_libunwind having some uninitialised fields ...................................................................... gsh_libunwind having some uninitialised fields find uninitialized fileds by valgrind: ==95935== 24 errors in context 3 of 82: ==95935== Syscall param write(buf) points to uninitialised byte(s) ==95935== at 0x7CC69BD: syscall (in /usr/lib64/libc-2.28.so) ==95935== by 0x403C199: ??? (in /usr/local/nutanix/clanglibs/libunwind.so.8.0.1) ==95935== by 0x403C398: ??? (in /usr/local/nutanix/clanglibs/libunwind.so.8.0.1) ==95935== by 0x403F7FD: ??? (in /usr/local/nutanix/clanglibs/libunwind.so.8.0.1) ==95935== by 0x403F6C7: ??? (in /usr/local/nutanix/clanglibs/libunwind.so.8.0.1) ==95935== by 0x403CD1F: _ULx86_64_step (in /usr/local/nutanix/clanglibs/libunwind.so.8.0.1) ==95935== by 0x4EF4B07: gsh_libunwind (log_functions.c:2940) ==95935== by 0x4EBE57A: crash_handler (nfs_init.c:276) ==95935== by 0x765DCEF: ??? (in /usr/lib64/libpthread-2.28.so) ==95935== Address 0x22f30000 is on thread 24's stack ==95935== in frame #6, created by gsh_libunwind (log_functions.c:2866) ==95935== Uninitialised value was created by a stack allocation ==95935== at 0x4EF4748: gsh_libunwind (log_functions.c:2866) Change-Id: Ief205b642d18cbffdde46b4982021a7c975c0688 Signed-off-by: Xueqian Hu <xh140312(a)outlook.com> --- M src/log/log_functions.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/91/1198891/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1198891?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ief205b642d18cbffdde46b4982021a7c975c0688 Gerrit-Change-Number: 1198891 Gerrit-PatchSet: 1 Gerrit-Owner: Xueqian Hu <xh140312(a)outlook.com>

1 0

[S] Change in ...nfs-ganesha[next]: Remove unused RDMA Configurations - rq_depth & sq_depth
by Rojin George (GerritHub) 02 Aug '24

02 Aug '24

Rojin George has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1198816?usp=email ) Change subject: Remove unused RDMA Configurations - rq_depth & sq_depth ...................................................................... Remove unused RDMA Configurations - rq_depth & sq_depth Change-Id: I270cb76d6808df6168a71532ea433051bb5ccc57 Signed-off-by: Rojin George <itsmerojin(a)gmail.com> --- M src/MainNFSD/nfs_rpc_dispatcher_thread.c M src/config_samples/config.txt M src/doc/man/ganesha-core-config.rst M src/include/gsh_config.h M src/support/nfs_read_conf.c 5 files changed, 0 insertions(+), 22 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/16/1198816/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1198816?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I270cb76d6808df6168a71532ea433051bb5ccc57 Gerrit-Change-Number: 1198816 Gerrit-PatchSet: 1 Gerrit-Owner: Rojin George <itsmerojin(a)gmail.com>

1 0