August 2026 - Devel - Nfs Ganesha List Archives

[XS] Change in ...nfs-ganesha[next]: Fix lttng traces in nfs4_op_copy

by Name of user not set (GerritHub)

mivry(a)google.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246530?usp=email ) Change subject: Fix lttng traces in nfs4_op_copy ...................................................................... Fix lttng traces in nfs4_op_copy With the current changes Ganesha did not compile with lttng enabled Change-Id: I67f1ba5b3fc6c4ef4141e0f1639c1e6a1853152f Signed-off-by: Miki Ivry <mivry(a)google.com> --- M src/Protocols/NFS/nfs4_op_copy.c 1 file changed, 3 insertions(+), 5 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/30/1246530/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246530?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I67f1ba5b3fc6c4ef4141e0f1639c1e6a1853152f Gerrit-Change-Number: 1246530 Gerrit-PatchSet: 1 Gerrit-Owner: mivry(a)google.com

7 hours, 30 minutes

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: Improve CT_ASSERT macro and add ifndef to it

by Name of user not set (GerritHub)

mivry(a)google.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246529?usp=email ) Change subject: Improve CT_ASSERT macro and add ifndef to it ...................................................................... Improve CT_ASSERT macro and add ifndef to it Change-Id: Ib0312ac6b079c7841e05591cf6ca1cd6cb10d438 Signed-off-by: Miki Ivry <mivry(a)google.com> --- M src/include/common_utils.h 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/29/1246529/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246529?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ib0312ac6b079c7841e05591cf6ca1cd6cb10d438 Gerrit-Change-Number: 1246529 Gerrit-PatchSet: 1 Gerrit-Owner: mivry(a)google.com

7 hours, 30 minutes

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: Organize includes

by Name of user not set (GerritHub)

mivry(a)google.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246528?usp=email ) Change subject: Organize includes ...................................................................... Organize includes Change-Id: Id9512ae9c98bc74e58af6c7104264854509ec891 Signed-off-by: Miki Ivry <mivry(a)google.com> --- M src/idmapper/idmapper_monitoring.c M src/include/connection_manager.h M src/include/gsh_rpc.h M src/include/idmapper_monitoring.h 4 files changed, 10 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/28/1246528/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246528?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id9512ae9c98bc74e58af6c7104264854509ec891 Gerrit-Change-Number: 1246528 Gerrit-PatchSet: 1 Gerrit-Owner: mivry(a)google.com

7 hours, 30 minutes

1
0
0 / 0

Guidance: keeping `RecoveryRoot` inside an exported tree via a nested export with `Access_Type = None`

by purkaitabhinandan＠gmail.com

Hi — a design question rather than a bug report, and I'd like to check whether we're leaning on behaviour that is intended before we build on it. ### Setup - NFS-Ganesha **V6.5**, built with `USE_FSAL_VFS=ON`, and notably `USE_RADOS_RECOV=OFF` / `USE_RADOS_GRACE=OFF`, so the rados recovery backends are not available to us. - One Ganesha instance per volume, running in a container, single server (no active/active, no clustering). - The container exports a single block-backed filesystem, and the export is the **root** of that filesystem: ``` EXPORT { Export_Id = 1; Path = /data/export; Pseudo = /; Access_Type = RW; Squash = No_Root_Squash; SecType = sys; Protocols = 4; FSAL { Name = VFS; } } ``` ### Problem `RecoveryBackend = fs` defaults its `RecoveryRoot` to `/var/lib/nfs/ganesha`, which in our container is ephemeral — it is discarded on every restart, so `clid_count` is always 0 on start-up and no client can reclaim (`nfs4_op_open.c` returns `NFS4ERR_NO_GRACE` for `CLAIM_PREVIOUS`). The only durable storage the server has is the exported filesystem itself, which follows the server when it moves. So we would like `RecoveryRoot` to live on that filesystem — but since we export its root, the recovery directory would sit inside the exported tree, visible and writable by clients. ### What we're considering Add a second export covering just the recovery directory, with no access: ``` EXPORT { Export_Id = 2; Path = /data/export/.ganesha; Pseudo = /.ganesha; Access_Type = None; Protocols = 4; FSAL { Name = VFS; } } ``` ### What we observed (V6.5, FSAL_VFS) Both exports load: ``` Export ... 1 pseudo (/) path (/data/export) perms (... no_root_squash, RWrw, ...) Export ... 2 pseudo (/.ganesha) path (/data/export/.ganesha) perms (... ----, ...) NFSv4 pseudo file system successfully initialized ``` From a client — including **root** under `No_Root_Squash`: - `ls -a` on the share does **not** list `.ganesha` at all - `stat`/`cat` on that path return `ENOENT`, not `EACCES` - `rm -rf <share>/* <share>/.[!.]*` removes everything else and leaves the recovery data untouched - the parent export continues to serve reads and writes normally Controlled by removing only the second export and restarting: the same directory (same inode, mode 0700) then appears in `ls -a` and its contents are readable over NFS. So the nested export is unambiguously what makes it unreachable. ### Questions 1. **Is this a supported use of nested exports**, or are we relying on an accident? Is there an intended mechanism for excluding a subdirectory from an export that we've missed? 2. **Is the READDIR filtering intentional and stable?** We expected `EACCES` on traversal and instead the junction is omitted from the listing entirely, which is nicer for us — but we don't want to depend on it if it's incidental. 3. **Any correctness concern with `RecoveryRoot` living inside an exported tree?** The server writes its own client database into a path that is nominally part of an export, albeit one no client can enter. Is there re-entrancy, FSAL, or grace-period interaction we should worry about? 4. For a single-server, one-instance-per-volume deployment where the recovery directory travels with the exported filesystem, **is `fs` or `fs_ng` preferable?** We read `recovery_fs_ng.c` as adding atomic generation swaps via `rename()` + `symlink()`; our backing filesystem is ext4, so both are viable.

1 day, 11 hours

4
11
0 / 0

[S] Change in ...nfs-ganesha[next]: EXPORTS: Make Access_Check_Policy fields dynamically updateable

by Frank Filz (GerritHub)

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246298?usp=email ) Change subject: EXPORTS: Make Access_Check_Policy fields dynamically updateable ...................................................................... EXPORTS: Make Access_Check_Policy fields dynamically updateable Change-Id: Ib1329c947d40391f64e511d1329501440a40873f Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/support/exports.c 1 file changed, 10 insertions(+), 5 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/98/1246298/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246298?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ib1329c947d40391f64e511d1329501440a40873f Gerrit-Change-Number: 1246298 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

2 days

1
0
0 / 0

Announce Push of V15.2

by Frank Filz

Branch next Tag:V15.2 NOTE: This merge includes an ntirpc pullup, please update your submodule. Merge Highlights * Add configurable access check policies for READDIR and LOOKUP * Reorder operations in fsal_test_access to eliminate redundant getattrs calls. * QoS: fix NULL qos_block deref in qos_perexport_insert * Allow FSAL module to populate getdeviceinfo notifications * Fix NULL ev_p Crash During Blocked Lock Grant * ntirpc pullup to V15.2 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: b2d60cb3d Frank S. Filz V15.2 67c3843ee Frank S. Filz ntirpc pullup to V15.2 11feeb2ab Rajesh Prasad Fix NULL ev_p Crash During Blocked Lock Grant 02c482323 Haihua Yang Allow FSAL module to populate getdeviceinfo notifications aa69b37e2 Suhas Athani QoS: fix NULL qos_block deref in qos_perexport_insert f6fcb89c5 Inna Batenkov Reorder operations in fsal_test_access to eliminate redundant getattrs calls. 23700bfb1 Inna Batenkov Add configurable access check policies for READDIR and LOOKUP

2 days

1
0
0 / 0

[M] Change in ...nfs-ganesha[next]: Support export fencing via Server_Addrs

by Sachin Punadikar (GerritHub)

Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246011?usp=email ) Change subject: Support export fencing via Server_Addrs ...................................................................... Support export fencing via Server_Addrs Restrict access to the export on basis of which IP address is used by NFS client to access the export. This feature is useful when Ganesha is listening on all available n/w interfaces and administrator wants to provide access to the export only when the export is being accessed using a specific IP. Change-Id: I19133c3861e8a70a1c76c74d28c7f5aa91ce470d Signed-off-by: Sachin Punadikar <sachin.punadikar(a)ibm.com> --- M src/doc/man/ganesha-export-config.rst M src/include/export_mgr.h M src/support/export_mgr.c M src/support/exports.c 4 files changed, 105 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/11/1246011/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246011?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I19133c3861e8a70a1c76c74d28c7f5aa91ce470d Gerrit-Change-Number: 1246011 Gerrit-PatchSet: 1 Gerrit-Owner: Sachin Punadikar <sachin.punadikar(a)ibm.com>

4 days, 6 hours

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: QoS: fix NULL qos_block deref in qos_perexport_insert

by Suhas Athani (GerritHub)

Suhas Athani has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245955?usp=email ) Change subject: QoS: fix NULL qos_block deref in qos_perexport_insert ...................................................................... QoS: fix NULL qos_block deref in qos_perexport_insert qos_perexport_insert(export, NULL) is valid and means "use g_qos_config" via lqos_block. The USE_MONITORING path still used qos_block->qos_type, which SIGSEGV'd when EnableExportQosBwControl passed NULL. Use lqos_block for the Per_Export metrics check. Crash site: nfs_qos.c qos_perexport_insert(), qos_block == NULL. Change-Id: I04a982e8c3b5142c9f0c99e2a8d645e6a6ee98d3 Signed-off-by: Suhas Athani <Suhas.Athani(a)ibm.com> --- M src/MainNFSD/nfs_qos.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/55/1245955/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245955?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I04a982e8c3b5142c9f0c99e2a8d645e6a6ee98d3 Gerrit-Change-Number: 1245955 Gerrit-PatchSet: 1 Gerrit-Owner: Suhas Athani <Suhas.Athani(a)ibm.com>

4 days, 13 hours

1
0
0 / 0

[L] Change in ...nfs-ganesha[next]: gRPC: add Per_Client QoS admin RPCs

by Suhas Athani (GerritHub)

Suhas Athani has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245950?usp=email ) Change subject: gRPC: add Per_Client QoS admin RPCs ...................................................................... gRPC: add Per_Client QoS admin RPCs Add gRPC equivalents of the Per_Client D-Bus QoS methods on org.ganesha.nfsd.qos (QosMgr). RPCs - GetClientBandwidth / SetClientBandwidth - GetClientTokens / SetClientTokens - GetClientIOPS / SetClientIOPS - EnableExportQosBwControl / DisableExportQosBwControl These land on qosService.QosMgr, with C helpers in nfs_qosmgr.c and handlers in nfsServiceServer.cc. Behavior matches the existing D-Bus methods: lookup the client by IP, then get/set rbucket/wbucket limits. Change-Id: I8b3a241a98f0b6835260efa4871f2346160f3c71 Signed-off-by: Suhas Athani <Suhas.Athani(a)ibm.com> --- M src/MainNFSD/nfs_qos.c M src/grpc_server/GrpcServer.cc M src/grpc_server/GrpcServer.h M src/grpc_server/nfsService.h M src/grpc_server/nfsServiceServer.cc A src/grpc_server/proto/qosService.proto A src/include/nfs_qos_grpc.h M src/support/nfs_qosmgr.c 8 files changed, 916 insertions(+), 24 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/50/1245950/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245950?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I8b3a241a98f0b6835260efa4871f2346160f3c71 Gerrit-Change-Number: 1245950 Gerrit-PatchSet: 1 Gerrit-Owner: Suhas Athani <Suhas.Athani(a)ibm.com>

4 days, 13 hours

1
0
0 / 0

[M] Change in ...nfs-ganesha[next]: Fix NULL ev_p Crash During Blocked Lock Grant

by Rajesh Prasad (GerritHub)

Rajesh Prasad has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245847?usp=email ) Change subject: Fix NULL ev_p Crash During Blocked Lock Grant ...................................................................... Fix NULL ev_p Crash During Blocked Lock Grant Bug: Ganesha crashes with a NULL dereference in `svc_rqst_expire_insert` when granting a blocked NFSv4 lock to a client that disconnected before the grant was attempted. Event Sequence: Client A - Acquires lock on file F Client B - Requests same lock; placed in blocked-lock queue (`STATE_BLOCKING`) Client B - Disconnect — `svc_rqst_unreg()` clears `rec->ev_p = NULL Client A - Issues `LOCKU` — lock released Ganesha - Calls `grant_blocked_locks()` — Client B's entry is the first candidate Ganesha - `nfsv4_granted_callback()` → `nfs_rpc_cb_single()` → `nfs_rpc_call()` → `CLNT_CALL_BACK()` → `clnt_req_callback()` → `svc_rqst_expire_insert()` CRASH - `sr_rec = cx->cx_rec->ev_p` is `NULL` → `mutex_lock(sr_rec->)` → SIGSEGV Fix: Before building the `CB_COMPOUND` payload, verify the client still has a working back channel. NFSv4.0 — read the `cb_chan_down` flag NFSv4.1/4.2 — scan `cb_session_list` under `cid_mutex` for any session that has `session_bc_up` set Handle RPC failure case - Covers the narrow race where the transport is destroyed after the pre-check passes but before (or during) the RPC send. If RPC failed, remove entry, try next. Used `STATE_ESTALE` to cleans up correctly - `try_to_grant_lock()` handles the return value of the callback: ``` STATE_LOCK_BLOCKED → restore sle_blocked, leave in list (will retry) STATE_SUCCESS → return (lock granted, entry promoted) anything else → fall through to remove_from_locklist() ``` `STATE_ESTALE` is "anything else", so the entry is removed. `grant_blocked_locks()` uses `glist_for_each_safe`, so after the entry is removed the loop automatically advances to the next blocked waiter. Change-Id: I119d51ff60fb20022a1e38e3c1c510da8f45dcb2 Signed-off-by: Rajesh Prasad <raprasad(a)redhat.com> --- M src/Protocols/NFS/nfs4_op_lock.c 1 file changed, 69 insertions(+), 7 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/47/1245847/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245847?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I119d51ff60fb20022a1e38e3c1c510da8f45dcb2 Gerrit-Change-Number: 1245847 Gerrit-PatchSet: 1 Gerrit-Owner: Rajesh Prasad <raprasad(a)redhat.com>

5 days, 9 hours

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

Devel August 2026