August 2026 - Devel - NFS Ganesha List Archives

[XS] Change in ...nfs-ganesha[next]: Guard the <sys/sysinfo.h> include with HAVE_PROCPS
by Bjorn Leffler (GerritHub) 25 Aug '26

25 Aug '26

Bjorn Leffler has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246767?usp=email ) Change subject: Guard the <sys/sysinfo.h> include with HAVE_PROCPS ...................................................................... Guard the <sys/sysinfo.h> include with HAVE_PROCPS struct sysinfo and sysinfo() are used only by dynamic_metrics__mem_info(), which is itself inside #ifdef HAVE_PROCPS, but the include is unconditional. It is dead weight whenever procps is absent, and a hard failure on platforms that have no <sys/sysinfo.h>. Change-Id: I0f6c1ef98433628f383b4628880014626f342206 Signed-off-by: Bjorn Leffler <github(a)leffler.org> --- M src/monitoring/dynamic_metrics.cc 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/67/1246767/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246767?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I0f6c1ef98433628f383b4628880014626f342206 Gerrit-Change-Number: 1246767 Gerrit-PatchSet: 1 Gerrit-Owner: Bjorn Leffler <github(a)leffler.org>

1 0

[XS] Change in ...nfs-ganesha[next]: Give MY_RTLD_FLAGS a fallback definition
by Bjorn Leffler (GerritHub) 25 Aug '26

25 Aug '26

Bjorn Leffler has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246766?usp=email ) Change subject: Give MY_RTLD_FLAGS a fallback definition ...................................................................... Give MY_RTLD_FLAGS a fallback definition The #if/#elif chain covers LINUX and FREEBSD only, so on any other platform MY_RTLD_FLAGS is left undefined and the two dlopen() calls in this file fail to compile. RTLD_DEEPBIND is a glibc extension, so the FREEBSD arm already holds the portable flags. Turning it into #else covers every other platform without changing what LINUX or FREEBSD get. Change-Id: I0957eea5382e23e1477a9d378550b65ef825083d Signed-off-by: Bjorn Leffler <github(a)leffler.org> --- M src/config_parsing/conf_url.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/66/1246766/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246766?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I0957eea5382e23e1477a9d378550b65ef825083d Gerrit-Change-Number: 1246766 Gerrit-PatchSet: 1 Gerrit-Owner: Bjorn Leffler <github(a)leffler.org>

1 0

[XS] Change in ...nfs-ganesha[next]: Initialise export_opt_lock statically
by Bjorn Leffler (GerritHub) 25 Aug '26

25 Aug '26

Bjorn Leffler has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246765?usp=email ) Change subject: Initialise export_opt_lock statically ...................................................................... Initialise export_opt_lock statically nfsd is built from MainNFSD/nfs_main.c, which never calls PTHREAD_RWLOCK_init() on export_opt_lock -- only the library entry point nfs_lib.c does -- yet export_defaults_commit() write-locks it while reading exports. A zeroed pthread_rwlock_t happens to be a valid unlocked lock on glibc, so this goes unnoticed there. It is not guaranteed by POSIX, and pthread implementations that validate the lock reject it: export_defaults_commit :RW LOCK :CRIT :Error 22, write locking PTHREAD_RWLOCK_INITIALIZER is all-zero on glibc, so the generated code is unchanged there. Change-Id: Iee1852e724fb8788abd01bcb05dc9ac7f4176625 Signed-off-by: Bjorn Leffler <github(a)leffler.org> --- M src/support/exports.c 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/65/1246765/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246765?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iee1852e724fb8788abd01bcb05dc9ac7f4176625 Gerrit-Change-Number: 1246765 Gerrit-PatchSet: 1 Gerrit-Owner: Bjorn Leffler <github(a)leffler.org>

1 0

[M] Change in ...nfs-ganesha[next]: Fix compilation error when build time flag USE_DBUS=OFF is used
by Bjorn Leffler (GerritHub) 24 Aug '26

24 Aug '26

Bjorn Leffler has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246697?usp=email ) Change subject: Fix compilation error when build time flag USE_DBUS=OFF is used ...................................................................... Fix compilation error when build time flag USE_DBUS=OFF is used The gRPC stats API -- grpc_reset_stats(), grpc_disable_stats(), grpc_get_auth_stats(), grpc_get_v4_full_stats() and server_grpc_fill_nfsmon_iostats() -- calls reset_server_stats(), reset_fsal_stats(), reset_client_stats(), reset_export_stats(), reset_clnt_allops_stats(), server_nfsmon_export_iostats() and the optnlm/optmnt/optqta tables unconditionally. All of those are declared or defined inside #ifdef USE_DBUS, so a build with USE_DBUS=OFF fails: src/support/export_mgr.c: error: implicit declaration of function 'reset_fsal_stats' src/support/server_stats.c: error: 'optnlm' undeclared ld: undefined reference to 'reset_server_stats' None of the affected declarations or definitions takes a DBus type, so they move outside the guard rather than being restructured, keeping the change small. The genuine DBus reporters -- server_dbus_total_ops(), server_dbus_fast_ops() and global_dbus_total_ops() -- stay guarded, as do the inner _USE_NFS3 / _USE_NLM / _USE_RQUOTA guards on the op-name tables. Change-Id: Ia187d531bd1be596e860ddcbae6176a6f993d50b Signed-off-by: Bjorn Leffler <github(a)leffler.org> --- M src/include/server_stats_private.h M src/support/client_mgr.c M src/support/export_mgr.c M src/support/server_stats.c 4 files changed, 90 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/97/1246697/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246697?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia187d531bd1be596e860ddcbae6176a6f993d50b Gerrit-Change-Number: 1246697 Gerrit-PatchSet: 1 Gerrit-Owner: Bjorn Leffler <github(a)leffler.org>

1 0

[XS] Change in ...nfs-ganesha[next]: Fix lttng traces in nfs4_op_copy
by Name of user not set (GerritHub) 23 Aug '26

23 Aug '26

mivry(a)google.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246530?usp=email ) Change subject: Fix lttng traces in nfs4_op_copy ...................................................................... Fix lttng traces in nfs4_op_copy With the current changes Ganesha did not compile with lttng enabled Change-Id: I67f1ba5b3fc6c4ef4141e0f1639c1e6a1853152f Signed-off-by: Miki Ivry <mivry(a)google.com> --- M src/Protocols/NFS/nfs4_op_copy.c 1 file changed, 3 insertions(+), 5 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/30/1246530/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246530?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I67f1ba5b3fc6c4ef4141e0f1639c1e6a1853152f Gerrit-Change-Number: 1246530 Gerrit-PatchSet: 1 Gerrit-Owner: mivry(a)google.com

1 0

[S] Change in ...nfs-ganesha[next]: Improve CT_ASSERT macro and add ifndef to it
by Name of user not set (GerritHub) 23 Aug '26

23 Aug '26

mivry(a)google.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246529?usp=email ) Change subject: Improve CT_ASSERT macro and add ifndef to it ...................................................................... Improve CT_ASSERT macro and add ifndef to it Change-Id: Ib0312ac6b079c7841e05591cf6ca1cd6cb10d438 Signed-off-by: Miki Ivry <mivry(a)google.com> --- M src/include/common_utils.h 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/29/1246529/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246529?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ib0312ac6b079c7841e05591cf6ca1cd6cb10d438 Gerrit-Change-Number: 1246529 Gerrit-PatchSet: 1 Gerrit-Owner: mivry(a)google.com

1 0

[S] Change in ...nfs-ganesha[next]: Organize includes
by Name of user not set (GerritHub) 23 Aug '26

23 Aug '26

mivry(a)google.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246528?usp=email ) Change subject: Organize includes ...................................................................... Organize includes Change-Id: Id9512ae9c98bc74e58af6c7104264854509ec891 Signed-off-by: Miki Ivry <mivry(a)google.com> --- M src/idmapper/idmapper_monitoring.c M src/include/connection_manager.h M src/include/gsh_rpc.h M src/include/idmapper_monitoring.h 4 files changed, 10 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/28/1246528/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246528?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id9512ae9c98bc74e58af6c7104264854509ec891 Gerrit-Change-Number: 1246528 Gerrit-PatchSet: 1 Gerrit-Owner: mivry(a)google.com

1 0

Guidance: keeping `RecoveryRoot` inside an exported tree via a nested export with `Access_Type = None`
by purkaitabhinandan＠gmail.com 22 Aug '26

22 Aug '26

Hi — a design question rather than a bug report, and I'd like to check whether we're leaning on behaviour that is intended before we build on it. ### Setup - NFS-Ganesha **V6.5**, built with `USE_FSAL_VFS=ON`, and notably `USE_RADOS_RECOV=OFF` / `USE_RADOS_GRACE=OFF`, so the rados recovery backends are not available to us. - One Ganesha instance per volume, running in a container, single server (no active/active, no clustering). - The container exports a single block-backed filesystem, and the export is the **root** of that filesystem: ``` EXPORT { Export_Id = 1; Path = /data/export; Pseudo = /; Access_Type = RW; Squash = No_Root_Squash; SecType = sys; Protocols = 4; FSAL { Name = VFS; } } ``` ### Problem `RecoveryBackend = fs` defaults its `RecoveryRoot` to `/var/lib/nfs/ganesha`, which in our container is ephemeral — it is discarded on every restart, so `clid_count` is always 0 on start-up and no client can reclaim (`nfs4_op_open.c` returns `NFS4ERR_NO_GRACE` for `CLAIM_PREVIOUS`). The only durable storage the server has is the exported filesystem itself, which follows the server when it moves. So we would like `RecoveryRoot` to live on that filesystem — but since we export its root, the recovery directory would sit inside the exported tree, visible and writable by clients. ### What we're considering Add a second export covering just the recovery directory, with no access: ``` EXPORT { Export_Id = 2; Path = /data/export/.ganesha; Pseudo = /.ganesha; Access_Type = None; Protocols = 4; FSAL { Name = VFS; } } ``` ### What we observed (V6.5, FSAL_VFS) Both exports load: ``` Export ... 1 pseudo (/) path (/data/export) perms (... no_root_squash, RWrw, ...) Export ... 2 pseudo (/.ganesha) path (/data/export/.ganesha) perms (... ----, ...) NFSv4 pseudo file system successfully initialized ``` From a client — including **root** under `No_Root_Squash`: - `ls -a` on the share does **not** list `.ganesha` at all - `stat`/`cat` on that path return `ENOENT`, not `EACCES` - `rm -rf <share>/* <share>/.[!.]*` removes everything else and leaves the recovery data untouched - the parent export continues to serve reads and writes normally Controlled by removing only the second export and restarting: the same directory (same inode, mode 0700) then appears in `ls -a` and its contents are readable over NFS. So the nested export is unambiguously what makes it unreachable. ### Questions 1. **Is this a supported use of nested exports**, or are we relying on an accident? Is there an intended mechanism for excluding a subdirectory from an export that we've missed? 2. **Is the READDIR filtering intentional and stable?** We expected `EACCES` on traversal and instead the junction is omitted from the listing entirely, which is nicer for us — but we don't want to depend on it if it's incidental. 3. **Any correctness concern with `RecoveryRoot` living inside an exported tree?** The server writes its own client database into a path that is nominally part of an export, albeit one no client can enter. Is there re-entrancy, FSAL, or grace-period interaction we should worry about? 4. For a single-server, one-instance-per-volume deployment where the recovery directory travels with the exported filesystem, **is `fs` or `fs_ng` preferable?** We read `recovery_fs_ng.c` as adding atomic generation swaps via `rename()` + `symlink()`; our backing filesystem is ext4, so both are viable.

4 11

[S] Change in ...nfs-ganesha[next]: EXPORTS: Make Access_Check_Policy fields dynamically updateable
by Frank Filz (GerritHub) 21 Aug '26

21 Aug '26

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246298?usp=email ) Change subject: EXPORTS: Make Access_Check_Policy fields dynamically updateable ...................................................................... EXPORTS: Make Access_Check_Policy fields dynamically updateable Change-Id: Ib1329c947d40391f64e511d1329501440a40873f Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/support/exports.c 1 file changed, 10 insertions(+), 5 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/98/1246298/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246298?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ib1329c947d40391f64e511d1329501440a40873f Gerrit-Change-Number: 1246298 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

Announce Push of V15.2
by Frank Filz 21 Aug '26

21 Aug '26

Branch next Tag:V15.2 NOTE: This merge includes an ntirpc pullup, please update your submodule. Merge Highlights * Add configurable access check policies for READDIR and LOOKUP * Reorder operations in fsal_test_access to eliminate redundant getattrs calls. * QoS: fix NULL qos_block deref in qos_perexport_insert * Allow FSAL module to populate getdeviceinfo notifications * Fix NULL ev_p Crash During Blocked Lock Grant * ntirpc pullup to V15.2 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: b2d60cb3d Frank S. Filz V15.2 67c3843ee Frank S. Filz ntirpc pullup to V15.2 11feeb2ab Rajesh Prasad Fix NULL ev_p Crash During Blocked Lock Grant 02c482323 Haihua Yang Allow FSAL module to populate getdeviceinfo notifications aa69b37e2 Suhas Athani QoS: fix NULL qos_block deref in qos_perexport_insert f6fcb89c5 Inna Batenkov Reorder operations in fsal_test_access to eliminate redundant getattrs calls. 23700bfb1 Inna Batenkov Add configurable access check policies for READDIR and LOOKUP

1 0