August 2026 - Devel - NFS Ganesha List Archives

[S] Change in ...nfs-ganesha[next]: CEPH: Limit number of ceph clients in Ganesha
by Sachin Punadikar (GerritHub) 26 Aug '26

26 Aug '26

Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1247024?usp=email ) Change subject: CEPH: Limit number of ceph clients in Ganesha ...................................................................... CEPH: Limit number of ceph clients in Ganesha While creating export for CEPH FSAL, if different cmount_path has been provided, then a dedicated ceph client gets attached to Ganesha process to serve that export. Every new ceph client needs resources like memory and certain number of threads. This resource utilization demands to have upper limit on number of ceph clients. This limit should be configurable entity, which can be set by administrator based on load on the system. Change-Id: Ifb5e7215e56dcf063de4d2fd06d6b085fc93f60b Signed-off-by: Sachin Punadikar <sachin.punadikar(a)ibm.com> --- M src/FSAL/FSAL_CEPH/internal.h M src/FSAL/FSAL_CEPH/main.c M src/config_samples/config.txt M src/doc/man/ganesha-ceph-config.rst 4 files changed, 33 insertions(+), 6 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/24/1247024/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1247024?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ifb5e7215e56dcf063de4d2fd06d6b085fc93f60b Gerrit-Change-Number: 1247024 Gerrit-PatchSet: 1 Gerrit-Owner: Sachin Punadikar <sachin.punadikar(a)ibm.com>

1 0

[S] Change in ...nfs-ganesha[next]: gRPC: Fix compilation error when USE_DBUS=OFF & USE_GRPC=ON
by Name of user not set (GerritHub) 26 Aug '26

26 Aug '26

Vidya.Thumukunta(a)ibm.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1247013?usp=email ) Change subject: gRPC: Fix compilation error when USE_DBUS=OFF & USE_GRPC=ON ...................................................................... gRPC: Fix compilation error when USE_DBUS=OFF & USE_GRPC=ON Separate gRPC helpers from DBUS-specific code. Change-Id: I0dd8f240a23a0674394a5cc9700a84141a752b56 Signed-off-by: VidyaThumukunta <vidya.thumukunta(a)ibm.com> --- M src/support/export_mgr.c 1 file changed, 25 insertions(+), 20 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/13/1247013/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1247013?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I0dd8f240a23a0674394a5cc9700a84141a752b56 Gerrit-Change-Number: 1247013 Gerrit-PatchSet: 1 Gerrit-Owner: Vidya.Thumukunta(a)ibm.com

1 0

[S] Change in ...nfs-ganesha[next]: QoS: allow build with ENABLE_QOS and USE_DBUS=OFF
by Suhas Athani (GerritHub) 26 Aug '26

26 Aug '26

Suhas Athani has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1247012?usp=email ) Change subject: QoS: allow build with ENABLE_QOS and USE_DBUS=OFF ...................................................................... QoS: allow build with ENABLE_QOS and USE_DBUS=OFF - Decouple QoS admin from D-Bus so ENABLE_QOS=ON builds without USE_DBUS. - Compile nfs_qosmgr.c only when USE_DBUS or USE_GRPC is enabled. Change-Id: I9afce8a0a56e2030ee001d05182a138b23645897 Signed-off-by: Suhas Athani <Suhas.Athani(a)ibm.com> --- M src/MainNFSD/CMakeLists.txt M src/include/nfs_qos.h M src/include/nfs_qosmgr.h M src/support/nfs_qosmgr.c 4 files changed, 13 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/12/1247012/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1247012?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I9afce8a0a56e2030ee001d05182a138b23645897 Gerrit-Change-Number: 1247012 Gerrit-PatchSet: 1 Gerrit-Owner: Suhas Athani <Suhas.Athani(a)ibm.com>

1 0

[S] Change in ...nfs-ganesha[next]: Return NFS4ERR_REQ_TOO_BIG when a request exceeds ca_maxrequestsize
by Oscar Ou (GerritHub) 26 Aug '26

26 Aug '26

Oscar Ou has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246978?usp=email ) Change subject: Return NFS4ERR_REQ_TOO_BIG when a request exceeds ca_maxrequestsize ...................................................................... Return NFS4ERR_REQ_TOO_BIG when a request exceeds ca_maxrequestsize RFC 5661 section 2.10.6.4 states that if a request exceeds ca_maxrequestsize the reply will have the status NFS4ERR_REQ_TOO_BIG, and that a replier MAY return it as the status for the first operation (SEQUENCE), "which means that no operations in the request executed and that the state of the slot in the reply cache is unchanged". That is the variant implemented here, so the check is made before the slot is looked up and locked. The same section also says the replier SHOULD set the error on the operation that exceeds the limit; returning it on SEQUENCE is the explicitly permitted alternative and keeps the reply cache slot untouched, which is why it is preferred here. Fixes pynfs 4.1 st_sequence.testRequestTooBig (SEQ6), which negotiates ca_maxrequestsize = 512 and then sends a COMPOUND carrying a 500 byte LOOKUP name. Before this change the COMPOUND was executed and the test got NFS4ERR_NAMETOOLONG: SEQ6 st_sequence.testRequestTooBig : FAILURE OP_LOOKUP should return NFS4ERR_REQ_TOO_BIG, instead got NFS4ERR_NAMETOOLONG Change-Id: I5a80c49bcb88bd0fcd3b23bfda68b14c91f36b88 Signed-off-by: Oscar Ou <oscarou(a)synology.com> --- M src/Protocols/NFS/nfs4_op_sequence.c 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/78/1246978/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246978?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I5a80c49bcb88bd0fcd3b23bfda68b14c91f36b88 Gerrit-Change-Number: 1246978 Gerrit-PatchSet: 1 Gerrit-Owner: Oscar Ou <oscarou(a)synology.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Fix buffer overflow risk with strcpy in nfs_ip_name_add
by Mike Borozdin (GerritHub) 25 Aug '26

25 Aug '26

Mike Borozdin has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246969?usp=email ) Change subject: Fix buffer overflow risk with strcpy in nfs_ip_name_add ...................................................................... Fix buffer overflow risk with strcpy in nfs_ip_name_add In nfs_ip_name_add, replace unsafe strcpy with bounded strlcpy to cap the string copy operation to maxsize, avoiding potential buffer overflow risk. Change-Id: I828fd2459ed2978814d9371d4778182127bf82cc Signed-off-by: Mike Borozdin <nolongemails(a)gmail.com> --- M src/support/nfs_ip_name.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/69/1246969/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246969?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I828fd2459ed2978814d9371d4778182127bf82cc Gerrit-Change-Number: 1246969 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Borozdin <nolongemails(a)gmail.com>

1 0

[M] Change in ...nfs-ganesha[next]: XDR: stop consuming the entry3/entryplus3 discriminator twice
by Mark Ruvald Pedersen (GerritHub) 25 Aug '26

25 Aug '26

Mark Ruvald Pedersen has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246962?usp=email ) Change subject: XDR: stop consuming the entry3/entryplus3 discriminator twice ...................................................................... XDR: stop consuming the entry3/entryplus3 discriminator twice xdr_dirlist3() and xdr_dirlistplus3() wrapped the entry3/entryplus3 list walkers in xdr_pointer(). Both layers read a "value follows" boolean, but RFC 1813 puts only one in front of each element: [bool=TRUE][entry][bool=TRUE][entry] ... [bool=FALSE] xdr_pointer() consumed the real boolean, so the walker then read the high 32 bits of the first entry's fileid3 as its own discriminator. Both outcomes are broken, and which one you get depends on the server: - High word zero: the walker stops immediately, leaving the zeroed node xdr_pointer() had already allocated as an entry whose name is NULL, and eof is then read from the fileid's low word. FSAL_PROXY_V3 walks that entry and calls strcmp() on the NULL name. - High word non-zero: the stream desyncs, so the following filename3 length is read from the wrong offset. Both were observed against NetApp ONTAP volumes. One puts the significant bits in the upper half -- a fileid of 9242200323076915308 is 0x8042e43a0000006c, so XDR puts 0x8042e43a on the wire first -- and READDIRPLUS against it fails with xdr_string_decode ERROR size 785966203 > max 8192 proxyv3_call: Failed to do xdr_replymsg Another volume hands out fileids below 2^32 and crashed instead. This is very likely the bug behind issue #1142. Only FSAL_PROXY_V3 decodes these. The server encodes non-empty replies through the uio path in xdr_dirlist3_encode() and xdr_dirlistplus3_encode(), and so never exercised the defect; empty continuations do reach the fallback encoder, but both the old and the new code emit [FALSE][eof] correctly there. Encode and decode were wrong symmetrically, so a round trip through this code agreed with itself even though neither direction matched the wire format. Give the walkers the whole chain: they now take the address of the caller's head pointer and own the per-element boolean, and the dirlist functions call them directly instead of through xdr_pointer(). They are renamed to xdr_entry3_list() and xdr_entryplus3_list() and made static, rather than keeping the established rpcgen-style xdr_entry3()/xdr_entryplus3() names with a changed signature. Both call sites are in this file, so nothing else needs them, and an out-of-tree caller now fails to link instead of silently reinterpreting a fileid3 as a pointer. A FALSE discriminator also has to clear the caller's head pointer the way xdr_pointer() did, otherwise decoding an empty or shorter list into a reused destination leaves the previous entries in place. While here, fix a use-after-free on the XDR_FREE path. It saved &(*ent)->nextentry and dereferenced it after freeing the object that field lives in; save the successor by value instead. Note that this fixes directory listing only. Reading file contents through FSAL_PROXY_V3 additionally requires the xdrmem_fillbufs() fix in ntirpc, submitted as nfs-ganesha/ntirpc#408; without it a proxied READ returns the front of the RPC reply rather than the payload. This patch deliberately does not bump the src/libntirpc submodule, so it applies cleanly on top of the current pin. Signed-off-by: Mark Ruvald Pedersen <wabsie(a)gmail.com> Change-Id: Ib547cd2223cc07be8c02f7d7a3703ed018b1889d --- M src/Protocols/XDR/xdr_nfs23.c M src/include/nfs23.h 2 files changed, 102 insertions(+), 48 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/62/1246962/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246962?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ib547cd2223cc07be8c02f7d7a3703ed018b1889d Gerrit-Change-Number: 1246962 Gerrit-PatchSet: 1 Gerrit-Owner: Mark Ruvald Pedersen <wabsie(a)gmail.com>

1 0

[S] Change in ...nfs-ganesha[next]: doc: add missing man pages to CMakeLists.txt
by Mike Borozdin (GerritHub) 25 Aug '26

25 Aug '26

Mike Borozdin has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246948?usp=email ) Change subject: doc: add missing man pages to CMakeLists.txt ...................................................................... doc: add missing man pages to CMakeLists.txt Change-Id: I223a7d4d8f53dcf68492f0a2bf74a562b351c69b Signed-off-by: Mike Borozdin <nolongemails(a)gmail.com> --- M src/doc/man/CMakeLists.txt 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/48/1246948/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246948?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I223a7d4d8f53dcf68492f0a2bf74a562b351c69b Gerrit-Change-Number: 1246948 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Borozdin <nolongemails(a)gmail.com>

1 0

[S] Change in ...nfs-ganesha[next]: Add NFS4ERR_REQ_TOO_BIG check for SEQ6
by Animesh Javali (GerritHub) 25 Aug '26

25 Aug '26

Animesh Javali has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246883?usp=email ) Change subject: Add NFS4ERR_REQ_TOO_BIG check for SEQ6 ...................................................................... Add NFS4ERR_REQ_TOO_BIG check for SEQ6 Verify the size of the request against maxrequestsize after XDR decode in nfs4_op_lookup(). Return NFS4ERR_REQ_TOO_BIG if the request exceeds this limit. Change-Id: I74caa2644efe019ee4933b232a50ca1d19b38414 Signed-off-by: Animesh Javali <Animesh.Javali(a)ibm.com> --- M src/MainNFSD/nfs_worker_thread.c M src/Protocols/NFS/nfs4_Compound.c M src/Protocols/NFS/nfs4_op_lookup.c M src/include/nfs_proto_data.h 4 files changed, 29 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/83/1246883/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246883?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I74caa2644efe019ee4933b232a50ca1d19b38414 Gerrit-Change-Number: 1246883 Gerrit-PatchSet: 1 Gerrit-Owner: Animesh Javali <Animesh.Javali(a)ibm.com>

1 0

[XS] Change in ...nfs-ganesha[next]: gRPC: Fix build issues with USE_DBUS=OFF
by Name of user not set (GerritHub) 24 Aug '26

24 Aug '26

Vidya.Thumukunta(a)ibm.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246776?usp=email ) Change subject: gRPC: Fix build issues with USE_DBUS=OFF ...................................................................... gRPC: Fix build issues with USE_DBUS=OFF Change-Id: I1753996e5014172d4569100762e0c38e2f63d585 Signed-off-by: VidyaThumukunta <vidya.thumukunta(a)ibm.com> --- M src/idmapper/idmapper.c M src/support/export_mgr.c M src/support/server_stats.c 3 files changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/76/1246776/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246776?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1753996e5014172d4569100762e0c38e2f63d585 Gerrit-Change-Number: 1246776 Gerrit-PatchSet: 1 Gerrit-Owner: Vidya.Thumukunta(a)ibm.com

1 0

[XS] Change in ...nfs-ganesha[next]: Pass a struct in6_addr to IN6_IS_ADDR_UNSPECIFIED
by Bjorn Leffler (GerritHub) 24 Aug '26

24 Aug '26

Bjorn Leffler has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246768?usp=email ) Change subject: Pass a struct in6_addr to IN6_IS_ADDR_UNSPECIFIED ...................................................................... Pass a struct in6_addr to IN6_IS_ADDR_UNSPECIFIED is_inaddrany() passes sin6_addr.s6_addr, the byte array. glibc's macro casts its argument to uint32_t * so either form works there, but implementations that treat it as a struct in6_addr * reject the array. RFC 2553 specifies the argument as a struct in6_addr *; passing &sin6_addr is correct everywhere and generates the same code on glibc. Change-Id: Id153d99297c43aeefb18741485339df1eb950dfc Signed-off-by: Bjorn Leffler <github(a)leffler.org> --- M src/support/ip_utils.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/68/1246768/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246768?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id153d99297c43aeefb18741485339df1eb950dfc Gerrit-Change-Number: 1246768 Gerrit-PatchSet: 1 Gerrit-Owner: Bjorn Leffler <github(a)leffler.org>

1 0