[M] Change in ...nfs-ganesha[next]: Add NFS_CORE_PARAM Mem_Stats_Disable for memory statistics capture
by Nishant Puri (GerritHub)
Nishant Puri has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245787?usp=email )
Change subject: Add NFS_CORE_PARAM Mem_Stats_Disable for memory statistics capture
......................................................................
Add NFS_CORE_PARAM Mem_Stats_Disable for memory statistics capture
Introduce Mem_Stats_Disable (default false) to skip gsh_malloc/gsh_free
per-component counter updates when operators do not need mem_stats.
When disabled, ganesha_stats mem_stats show reports zero for all counters;
mem_stats status reports active/inactive via new GetMemoryStatsStatus
D-Bus method.
Log enabled/disabled once at init (COMPONENT_INIT). Skip shutdown
gsh_log_mem_stats() when capture is inactive. Option is read at daemon
startup only; SIGHUP config reload does not change it.
Document the option in ganesha-core-config.rst.
Change-Id: I2e6ff0f43014472e4e8eecaa8a70948af657741a
Signed-off-by: Nishant Puri <npuri(a)redhat.com>
---
M src/MainNFSD/nfs_init.c
M src/doc/man/ganesha-core-config.rst
M src/include/gsh_config.h
M src/include/server_stats.h
M src/scripts/ganeshactl/Ganesha/glib_dbus_stats.py
M src/scripts/ganeshactl/ganesha_stats.py
M src/support/nfs_read_conf.c
M src/support/server_stats.c
8 files changed, 171 insertions(+), 36 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/87/1245787/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245787?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I2e6ff0f43014472e4e8eecaa8a70948af657741a
Gerrit-Change-Number: 1245787
Gerrit-PatchSet: 1
Gerrit-Owner: Nishant Puri <npuri(a)redhat.com>
5 days, 13 hours
[M] Change in ...nfs-ganesha[next]: Enhance client ID diagnostics, IP logging, and reaper trace control 1...
by Name of user not set (GerritHub)
inneek(a)gmail.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245716?usp=email )
Change subject: Enhance client ID diagnostics, IP logging, and reaper trace control 1. Add dump_client_owners_and_states() to log client owners and state IDs when extra references block client expiration. 2. Log a warning in EXCHANGE_ID when same client owner name connects from different IP addresses. 3. Suppress LTTng trace spam when the client reaper loops >100 times waiting for state owner refcounts to drop.
......................................................................
Enhance client ID diagnostics, IP logging, and reaper trace control
1. Add dump_client_owners_and_states() to log client owners and state IDs
when extra references block client expiration.
2. Log a warning in EXCHANGE_ID when same client owner name connects from
different IP addresses.
3. Suppress LTTng trace spam when the client reaper loops >100 times waiting
for state owner refcounts to drop.
Change-Id: I5e758ba124fa554188f2ae961b7ca27b5e4e04bc
Signed-off-by: Inna Batenkov <inneek(a)gmail.com>
---
M src/Protocols/NFS/nfs4_op_exchange_id.c
M src/SAL/nfs4_clientid.c
M src/SAL/state_misc.c
M src/include/sal_functions.h
4 files changed, 201 insertions(+), 13 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/16/1245716/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245716?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I5e758ba124fa554188f2ae961b7ca27b5e4e04bc
Gerrit-Change-Number: 1245716
Gerrit-PatchSet: 1
Gerrit-Owner: inneek(a)gmail.com
6 days, 5 hours
[S] Change in ...nfs-ganesha[next]: Reorder operations in fsal_test_access to eliminate redundant getattr...
by Name of user not set (GerritHub)
inneek(a)gmail.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245714?usp=email )
Change subject: Reorder operations in fsal_test_access to eliminate redundant getattrs calls.
......................................................................
Reorder operations in fsal_test_access to eliminate redundant getattrs calls.
When access_type is 0 ("nothing requested"), fsal_test_access previously called
getattrs on the object handle before checking access_type. Moving the
access_type check to the beginning of fsal_test_access avoids executing an unnecessary getattrs RPC query when access_type == 0
Change-Id: I791a175e3a92f2fb449f856a9c3f7918258dffdd
Signed-off-by: Inna Batenkov <inneek(a)gmail.com>
---
M src/FSAL/access_check.c
1 file changed, 17 insertions(+), 8 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/14/1245714/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245714?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I791a175e3a92f2fb449f856a9c3f7918258dffdd
Gerrit-Change-Number: 1245714
Gerrit-PatchSet: 1
Gerrit-Owner: inneek(a)gmail.com
6 days, 6 hours
Announce Push of V15.1
by Frank Filz
Branch next
Tag:V15.1
This merge includes some bug fixes and some enhancements to gRPC.
Merge Highlights
* Use GPFS-specific logrotate config for Ganesha packages
* Fix malformed legacy Python install bcond generation
* Fix gRPC build for two-arg gsh_free and C++ linkage of mem stats
* gRPC: Add gRPC FakeRecall API for CBSIM fake_recall
* Fix Coverity leak in ceph_register_nfs_service(Coverity: 651219)
* Github issue #1128 - Reuse common synchronization for UpdateExport
* Grpc: Extend ShowExports response with protocol summary
* memstats: fix comp-tag mismatches, and bpftrace audit
* FSAL/CEPH: Release invalidated dentry inode
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
Contents:
f35046ff9 Frank S. Filz V15.1
3a0dcc393 Sheng Li FSAL/CEPH: Release invalidated dentry inode
84093c189 Nishant Puri memstats: fix comp-tag mismatches, and bpftrace audit
28a7f28a7 VidyaThumukunta Grpc: Extend ShowExports response with protocol
summary
dcb5934ea VidyaThumukunta Github issue #1128 - Reuse common synchronization
for UpdateExport
2a8abe7ea Suhas Athani Fix Coverity leak in
ceph_register_nfs_service(Coverity: 651219)
bcd37c533 Suhas Athani gRPC: Add gRPC FakeRecall API for CBSIM fake_recall
fafff0966 Suhas Athani Fix gRPC build for two-arg gsh_free and C++ linkage
of mem stats
0353f0953 Prabhu Murugesan Fix malformed legacy Python install bcond
generation
624586f78 Prabhu Murugesan Use GPFS-specific logrotate config for Ganesha
packages
1 week, 2 days
[M] Change in ...nfs-ganesha[next]: memstats: fix comp-tag mismatches, and bpftrace audit
by Nishant Puri (GerritHub)
Nishant Puri has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245460?usp=email )
Change subject: memstats: fix comp-tag mismatches, and bpftrace audit
......................................................................
memstats: fix comp-tag mismatches, and bpftrace audit
Fix READDIR vio_base free tag (IO_BUFFER) and utf8string XDR_FREE via
free_utf8string() so PROTOCOL allocs are not freed as LIBNTIRPC.
Improve audit file: delete per-pointer BPF keys on free, larger hash maps,
and silence bpftrace delete() warnings.
Change-Id: I2eba1ca8ec9c91872d1836c926ad493d7932eb9c
Signed-off-by: Nishant Puri <npuri(a)redhat.com>
---
M src/Protocols/NFS/nfs4_op_readdir.c
M src/include/nfsv41.h
M src/scripts/bpftrace/README.md
M src/scripts/bpftrace/mem_comp_audit.bt
4 files changed, 68 insertions(+), 22 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/60/1245460/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245460?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I2eba1ca8ec9c91872d1836c926ad493d7932eb9c
Gerrit-Change-Number: 1245460
Gerrit-PatchSet: 1
Gerrit-Owner: Nishant Puri <npuri(a)redhat.com>
1 week, 3 days
[XS] Change in ...nfs-ganesha[next]: Fix Coverity leak in ceph_register_nfs_service(Coverity: 651219)
by Suhas Athani (GerritHub)
Suhas Athani has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245459?usp=email )
Change subject: Fix Coverity leak in ceph_register_nfs_service(Coverity: 651219)
......................................................................
Fix Coverity leak in ceph_register_nfs_service(Coverity: 651219)
Coverity CID 651219 flags a leak of the dlopen handle in
ceph_register_nfs_service() when dlsym() fails.
dlclose() the handle on that failure path. On success the mapping is
left open: register_service_to_ceph() starts a heartbeat thread whose
code and state live in libganesha_rados_urls.so.
Change-Id: I58053dc283e83cc30f5707fc62a9f9d31de8452f
Signed-off-by: Suhas Athani <Suhas.Athani(a)ibm.com>
---
M src/FSAL/FSAL_CEPH/main.c
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/59/1245459/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245459?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I58053dc283e83cc30f5707fc62a9f9d31de8452f
Gerrit-Change-Number: 1245459
Gerrit-PatchSet: 1
Gerrit-Owner: Suhas Athani <Suhas.Athani(a)ibm.com>
1 week, 3 days
[M] Change in ...nfs-ganesha[next]: NFS4: Implement NFSv4.1 session trunking via fs_locations discovery
by Name of user not set (GerritHub)
sragraha(a)redhat.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245444?usp=email )
Change subject: NFS4: Implement NFSv4.1 session trunking via fs_locations discovery
......................................................................
NFS4: Implement NFSv4.1 session trunking via fs_locations discovery
NFSv4.1 session trunking — the ability for a client to establish parallel
TCP connections to multiple server IP addresses within a single NFSv4.1
session — was not functional in nfs-ganesha. The Linux kernel NFS client
supports autonomous trunk discovery via the `trunkdiscovery` mount option
(kernel ≥ 5.16)
- Added `FS_LOCATION` config block to `EXPORT` allowing operators to
configure the trunk IP, pseudo root, and server address per export.
- Added `Trunking = true|false` boolean to `NFS_CORE_PARAM`.
- Added `fsal_fs_locations_t *export_fs_location` to `struct gsh_export`.
Change-Id: I23911aab19f7d87733dbb54350394a8047b2e1c2
Signed-off-by: Sreedhar Agraharam <sragraha(a)redhat.com>
---
M src/Protocols/NFS/nfs_proto_tools.c
M src/SAL/nfs4_clientid.c
M src/include/export_mgr.h
M src/include/gsh_config.h
M src/support/exports.c
M src/support/nfs_read_conf.c
6 files changed, 130 insertions(+), 11 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/44/1245444/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245444?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I23911aab19f7d87733dbb54350394a8047b2e1c2
Gerrit-Change-Number: 1245444
Gerrit-PatchSet: 1
Gerrit-Owner: sragraha(a)redhat.com
1 week, 3 days
[M] Change in ...nfs-ganesha[next]: Github issue #1128 - Reuse common synchronization for UpdateExport
by Name of user not set (GerritHub)
Vidya.Thumukunta(a)ibm.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245443?usp=email )
Change subject: Github issue #1128 - Reuse common synchronization for UpdateExport
......................................................................
Github issue #1128 - Reuse common synchronization for UpdateExport
Move the export synchronization helpers to common code and
reuse them from both the DBus and gRPC UpdateExport paths.
Invoke the common synchronization logic after successful
UpdateExport operations to keep the PseudoFS consistent
following dynamic export updates.
Change-Id: I47b3376c4da4ce9ebcf16667393dd5bea8a73d14
Signed-off-by: VidyaThumukunta <vidya.thumukunta(a)ibm.com>
---
M src/grpc_server/nfsServiceServer.cc
M src/include/export_mgr.h
M src/support/export_mgr.c
M src/support/exports.c
4 files changed, 34 insertions(+), 17 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/43/1245443/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245443?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I47b3376c4da4ce9ebcf16667393dd5bea8a73d14
Gerrit-Change-Number: 1245443
Gerrit-PatchSet: 1
Gerrit-Owner: Vidya.Thumukunta(a)ibm.com
1 week, 3 days
[M] Change in ...nfs-ganesha[next]: Grpc: Extend ShowExports response with protocol summary
by Name of user not set (GerritHub)
Vidya.Thumukunta(a)ibm.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245358?usp=email )
Change subject: Grpc: Extend ShowExports response with protocol summary
......................................................................
Grpc: Extend ShowExports response with protocol summary
Enhance the ShowExports gRPC API to include per-export protocol
activity, total operation count, and last update timestamp.
Also guard 9P-specific gRPC APIs with _USE_9P to align with the
build configuration when 9P support is disabled.
Change-Id: I3a71a46bcc6c98ae07e1f4d8b49d0d1a20f0bf47
Signed-off-by: VidyaThumukunta <vidya.thumukunta(a)ibm.com>
---
M src/grpc_server/nfsService.h
M src/grpc_server/nfsServiceServer.cc
M src/grpc_server/proto/exportService.proto
M src/include/server_stats_grpc.h
M src/support/server_stats.c
5 files changed, 76 insertions(+), 6 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/58/1245358/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245358?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I3a71a46bcc6c98ae07e1f4d8b49d0d1a20f0bf47
Gerrit-Change-Number: 1245358
Gerrit-PatchSet: 1
Gerrit-Owner: Vidya.Thumukunta(a)ibm.com
1 week, 4 days