[XS] Change in ...nfs-ganesha[next]: Fix Coverity leak in ceph_register_nfs_service(Coverity: 651219)
by Suhas Athani (GerritHub)
Suhas Athani has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245459?usp=email )
Change subject: Fix Coverity leak in ceph_register_nfs_service(Coverity: 651219)
......................................................................
Fix Coverity leak in ceph_register_nfs_service(Coverity: 651219)
Coverity CID 651219 flags a leak of the dlopen handle in
ceph_register_nfs_service() when dlsym() fails.
dlclose() the handle on that failure path. On success the mapping is
left open: register_service_to_ceph() starts a heartbeat thread whose
code and state live in libganesha_rados_urls.so.
Change-Id: I58053dc283e83cc30f5707fc62a9f9d31de8452f
Signed-off-by: Suhas Athani <Suhas.Athani(a)ibm.com>
---
M src/FSAL/FSAL_CEPH/main.c
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/59/1245459/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245459?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I58053dc283e83cc30f5707fc62a9f9d31de8452f
Gerrit-Change-Number: 1245459
Gerrit-PatchSet: 1
Gerrit-Owner: Suhas Athani <Suhas.Athani(a)ibm.com>
1 month
[M] Change in ...nfs-ganesha[next]: NFS4: Implement NFSv4.1 session trunking via fs_locations discovery
by Name of user not set (GerritHub)
sragraha(a)redhat.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245444?usp=email )
Change subject: NFS4: Implement NFSv4.1 session trunking via fs_locations discovery
......................................................................
NFS4: Implement NFSv4.1 session trunking via fs_locations discovery
NFSv4.1 session trunking — the ability for a client to establish parallel
TCP connections to multiple server IP addresses within a single NFSv4.1
session — was not functional in nfs-ganesha. The Linux kernel NFS client
supports autonomous trunk discovery via the `trunkdiscovery` mount option
(kernel ≥ 5.16)
- Added `FS_LOCATION` config block to `EXPORT` allowing operators to
configure the trunk IP, pseudo root, and server address per export.
- Added `Trunking = true|false` boolean to `NFS_CORE_PARAM`.
- Added `fsal_fs_locations_t *export_fs_location` to `struct gsh_export`.
Change-Id: I23911aab19f7d87733dbb54350394a8047b2e1c2
Signed-off-by: Sreedhar Agraharam <sragraha(a)redhat.com>
---
M src/Protocols/NFS/nfs_proto_tools.c
M src/SAL/nfs4_clientid.c
M src/include/export_mgr.h
M src/include/gsh_config.h
M src/support/exports.c
M src/support/nfs_read_conf.c
6 files changed, 130 insertions(+), 11 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/44/1245444/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245444?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I23911aab19f7d87733dbb54350394a8047b2e1c2
Gerrit-Change-Number: 1245444
Gerrit-PatchSet: 1
Gerrit-Owner: sragraha(a)redhat.com
1 month
[M] Change in ...nfs-ganesha[next]: Github issue #1128 - Reuse common synchronization for UpdateExport
by Name of user not set (GerritHub)
Vidya.Thumukunta(a)ibm.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245443?usp=email )
Change subject: Github issue #1128 - Reuse common synchronization for UpdateExport
......................................................................
Github issue #1128 - Reuse common synchronization for UpdateExport
Move the export synchronization helpers to common code and
reuse them from both the DBus and gRPC UpdateExport paths.
Invoke the common synchronization logic after successful
UpdateExport operations to keep the PseudoFS consistent
following dynamic export updates.
Change-Id: I47b3376c4da4ce9ebcf16667393dd5bea8a73d14
Signed-off-by: VidyaThumukunta <vidya.thumukunta(a)ibm.com>
---
M src/grpc_server/nfsServiceServer.cc
M src/include/export_mgr.h
M src/support/export_mgr.c
M src/support/exports.c
4 files changed, 34 insertions(+), 17 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/43/1245443/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245443?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I47b3376c4da4ce9ebcf16667393dd5bea8a73d14
Gerrit-Change-Number: 1245443
Gerrit-PatchSet: 1
Gerrit-Owner: Vidya.Thumukunta(a)ibm.com
1 month
[M] Change in ...nfs-ganesha[next]: Grpc: Extend ShowExports response with protocol summary
by Name of user not set (GerritHub)
Vidya.Thumukunta(a)ibm.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245358?usp=email )
Change subject: Grpc: Extend ShowExports response with protocol summary
......................................................................
Grpc: Extend ShowExports response with protocol summary
Enhance the ShowExports gRPC API to include per-export protocol
activity, total operation count, and last update timestamp.
Also guard 9P-specific gRPC APIs with _USE_9P to align with the
build configuration when 9P support is disabled.
Change-Id: I3a71a46bcc6c98ae07e1f4d8b49d0d1a20f0bf47
Signed-off-by: VidyaThumukunta <vidya.thumukunta(a)ibm.com>
---
M src/grpc_server/nfsService.h
M src/grpc_server/nfsServiceServer.cc
M src/grpc_server/proto/exportService.proto
M src/include/server_stats_grpc.h
M src/support/server_stats.c
5 files changed, 76 insertions(+), 6 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/58/1245358/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245358?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I3a71a46bcc6c98ae07e1f4d8b49d0d1a20f0bf47
Gerrit-Change-Number: 1245358
Gerrit-PatchSet: 1
Gerrit-Owner: Vidya.Thumukunta(a)ibm.com
1 month
[L] Change in ...nfs-ganesha[next]: gRPC: Add gRPC FakeRecall API for CBSIM fake_recall
by Suhas Athani (GerritHub)
Suhas Athani has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245349?usp=email )
Change subject: gRPC: Add gRPC FakeRecall API for CBSIM fake_recall
......................................................................
gRPC: Add gRPC FakeRecall API for CBSIM fake_recall
Introduce nfsService.FakeRecall/FakeRecall, taking client_id and
returning nfsProtoUtil.StatusResponse. The handler delegates to
a new C helper, grpc_cbsim_fake_recall(). The helper mirrors the
D-Bus CBSIM behavior: look up a confirmed client id, test the
callback channel, and submit a demonstration CB_RECALL.
Change-Id: Ibb35912e217a269f362c6421d4038bf6213f73c7
Signed-off-by: Suhas Athani <Suhas.Athani(a)ibm.com>
---
M src/MainNFSD/CMakeLists.txt
A src/MainNFSD/nfs_cbsim_grpc.c
M src/grpc_server/GrpcServer.cc
M src/grpc_server/GrpcServer.h
M src/grpc_server/nfsService.h
M src/grpc_server/nfsServiceClient.cc
M src/grpc_server/nfsServiceServer.cc
M src/grpc_server/proto/nfsService.proto
M src/include/abstract_mem.h
A src/include/nfs_cbsim_grpc.h
M src/include/nfs_rpc_callback.h
11 files changed, 327 insertions(+), 46 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/49/1245349/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245349?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ibb35912e217a269f362c6421d4038bf6213f73c7
Gerrit-Change-Number: 1245349
Gerrit-PatchSet: 1
Gerrit-Owner: Suhas Athani <Suhas.Athani(a)ibm.com>
1 month
[S] Change in ...nfs-ganesha[next]: Fix gRPC build for two-arg gsh_free and C++ linkage of mem stats
by Suhas Athani (GerritHub)
Suhas Athani has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245251?usp=email )
Change subject: Fix gRPC build for two-arg gsh_free and C++ linkage of mem stats
......................................................................
Fix gRPC build for two-arg gsh_free and C++ linkage of mem stats
- Pass `MEM_COMP_CONFIG` to `gsh_free` in `nfsServiceServer.cc`
(AddExport/UpdateExport), matching `export_mgr.c` and the updated
`gsh_free(p, comp)` API.
- Move `gsh_mem_stats_update_alloc` / `gsh_mem_stats_update_free`
declarations inside the `extern "C"` block in `abstract_mem.h` so
C++ callers link against the C symbols instead of mangled names.
Change-Id: Ic35d254957755caa5b2d10490857215fbdb7f2f1
Signed-off-by: Suhas Athani <Suhas.Athani(a)ibm.com>
---
M src/grpc_server/nfsServiceServer.cc
M src/include/abstract_mem.h
2 files changed, 8 insertions(+), 9 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/51/1245251/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245251?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ic35d254957755caa5b2d10490857215fbdb7f2f1
Gerrit-Change-Number: 1245251
Gerrit-PatchSet: 1
Gerrit-Owner: Suhas Athani <Suhas.Athani(a)ibm.com>
1 month
[M] Change in ...nfs-ganesha[next]: Make more use of noop_conf_init
by Frank Filz (GerritHub)
Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245202?usp=email )
Change subject: Make more use of noop_conf_init
......................................................................
Make more use of noop_conf_init
Several config blocks do not need their own .init function.
Change-Id: I0ee7117c738d4e7f805d82cb79acd672d58631c6
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
---
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_read_conf.c
M src/MainNFSD/nfs_init.c
M src/Protocols/9P/9p_read_conf.c
M src/SAL/recovery/recovery_rados_kv.c
M src/config_parsing/conf_url_rados.c
M src/support/nfs_ip_name.c
6 files changed, 16 insertions(+), 44 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/02/1245202/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245202?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I0ee7117c738d4e7f805d82cb79acd672d58631c6
Gerrit-Change-Number: 1245202
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>
1 month
[M] Change in ...nfs-ganesha[next]: clang-format fixup of several files
by Frank Filz (GerritHub)
Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245201?usp=email )
Change subject: clang-format fixup of several files
......................................................................
clang-format fixup of several files
Change-Id: Ie73e73b7fca94d956e6dea6435d1c65e1c532a85
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
---
M src/MainNFSD/nfs_init.c
M src/MainNFSD/nfs_rpc_dispatcher_thread.c
M src/grpc_server/nfsService.h
M src/grpc_server/nfsServiceServer.cc
M src/support/client_mgr.c
M src/support/nfs_read_conf.c
6 files changed, 48 insertions(+), 36 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/01/1245201/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1245201?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ie73e73b7fca94d956e6dea6435d1c65e1c532a85
Gerrit-Change-Number: 1245201
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>
1 month
Announce Push of V15.0
by Frank Filz
Branch next
Tag:V15.0
NOTE: This merge includes an ntirpc pullup, pleade update your submodule.
Features
* Memory statistics and accounting
* Grpc: Add CacheMgr gRPC APIs
Merge Highlights
* log: ignore duplicate conditional logging list entries
* Fix compilation error for USE_NFS3=OFF
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
Contents:
cf95ecf49 Frank S. Filz V15.0
21c88a58a Sachin Punadikar Fix compilation error for USE_NFS3=OFF
aa9472e52 VidyaThumukunta Grpc: Add CacheMgr gRPC APIs
adf2cc08b Nishant Puri memstats: add framework for runtime memory accounting
8432f4ff4 Nishant Puri log: ignore duplicate conditional logging list
entries
1 month, 1 week